go collector: add fips140ems runtime metric - #2092
Closed
wieghx wants to merge 2 commits into
Closed
Conversation
Go 1.25.13 and 1.26 expose /godebug/non-default-behavior/fips140ems:events. Regenerate the expected metric lists so Test and collectors allow-list tests pass on current CI toolchains. Signed-off-by: wieghx <gudemail1991@gmail.com>
Signed-off-by: wieghx <gudemail1991@gmail.com>
Member
|
I think this was already done, no? #2090 |
Contributor
Author
|
You're right — #2090 already regenerated the runtime metric allow-list, including |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Regenerate the Go collector expected-metric lists for Go 1.25 and 1.26 so they include the new runtime metric:
/godebug/non-default-behavior/fips140ems:events→
go_godebug_non_default_behavior_fips140ems_events_totalFiles were produced with the existing generators:
go run prometheus/gen_go_collector_metrics_set.go go1.26.6go run prometheus/collectors/gen_go_collector_set.go go1.26.6go1.25.13(whatactions/setup-gocurrently installs for1.25withcheck-latest: true)Why
mainTest has been red since 2026-08-17 (run 32022436024) with:This is separate from #2091 (
GatherAndFormat).How to verify
go test ./prometheus/ ./prometheus/collectors/ -count=1Also checked with
go1.25.13.cc @bwplotka
This PR was written in part with the assistance of generative AI.