Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix timestamp representation #1292

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix timestamp representation #1292

wants to merge 2 commits into from

Conversation

zeitlinger
Copy link
Member

Fixes #1277

@zeitlinger
fix timestamp style
e8ae943 
Signed-off-by: Gregor Zeitlinger <[email protected]>
@zeitlinger
fix timestamp style
ba12b5f 
Signed-off-by: Gregor Zeitlinger <[email protected]>
@zeitlinger zeitlinger self-assigned this Feb 27, 2025
@zeitlinger
Copy link
Member Author

@dhoard @fstab

this changes quite a lot - am I on the wrong track?

E.g. this would change in ExpositionFormatsTest:

image

@dhoard
Copy link
Collaborator

dhoard commented Feb 28, 2025

It feels like the correct approach to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zeitlinger zeitlinger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TextFormatUtil.writeTimestamp writes a value with a decimal point but the spec specifies an int64
2 participants
@zeitlinger @dhoard