fix(filesystem): add comma separator in mountOptionsString#3507
Open
Ray0907 wants to merge 1 commit intoprometheus:masterfrom
Open
fix(filesystem): add comma separator in mountOptionsString#3507Ray0907 wants to merge 1 commit intoprometheus:masterfrom
Ray0907 wants to merge 1 commit intoprometheus:masterfrom
Conversation
mountOptionsString was concatenating options without commas, breaking readonly dete Signed-off-by: Ray Tien <ray.tien0907@gmail.com>
Member
|
Needs sign off. Also consider preallocating the string array. Not that its needed but why not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mountOptionsString was concatenating options without commas, breaking
readonly dete
Fixes: #3484
Signed-off-by: Ray Tien ray.tien0907@gmail.com