fix: adopt codex-plugin-cc reliability guards#6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adopts the verified ContextRelay-relevant reliability patterns from openai/codex-plugin-cc without porting its plugin architecture or UX. This bounds backup timeout cleanup, daemon shutdown cleanup, and long-running Codex turns.
Changes
CONTEXTRELAY_BACKUP_KILL_GRACE_MS, withbackup_timeoutledger telemetry.runShutdownSteps, withdaemon_shutdownruntime event telemetry andCONTEXTRELAY_DAEMON_SHUTDOWN_STEP_TIMEOUT_MS.CONTEXTRELAY_TURN_MAX_MS, status/viewer exposure for the last watchdog fire, andturn_watchdogruntime events.Upstream References
sendBrokerShutdownhas no timeout — SessionEnd hook can hang indefinitely openai/codex-plugin-cc#288Testing
bun test src/unit-test/backup-runner.test.ts src/unit-test/shutdown.test.ts src/unit-test/codex-adapter.test.tsbun run typecheckbun run build:cli && bun run build:pluginbun run check→ 322 pass, 0 fail, 999 expect() calls; bundle sync, plugin version, and lockfile checks passed