feat(db): requestType discriminator + UserCommitment->ImageCaptcha rename#2635
Draft
HughParry wants to merge 1 commit into
Draft
feat(db): requestType discriminator + UserCommitment->ImageCaptcha rename#2635HughParry wants to merge 1 commit into
HughParry wants to merge 1 commit into
Conversation
…ageCaptcha Phase 1 of the captcha request consolidation (type layer only — no data migration, physical collections unchanged). - Add `RequestType` enum (session/powcaptcha/imagecaptcha/puzzlecaptcha) and a shared `RequestRecord` base; stamp `requestType` on every record schema via a per-type mongoose default (and explicitly on the pending-image placeholder). - Rename `UserCommitment*` -> `ImageCaptcha*` across types, schemas, the `IProviderDatabase` interface, the provider-DB methods and their callers, keeping @deprecated back-compat aliases so consumers migrate gradually. - Rename `ICaptchaDatabase.getCaptchas` result `userCommitmentRecords` -> `imageCaptchaRecords` (not aliasable). - Live Mongo model-name strings ("UserCommitment"/"PowCaptcha") deliberately left unchanged; casing inconsistency documented for the Phase 2 merge. - Add requestType unit test; update architecture.mmd. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
🤖 Generated with Claude Code