feat(user-access-policy): browser match dimension for access rules - #3162
Merged
Conversation
Mirrors the existing `os` dimension: rules can now be scoped to the browser classified server-side from the request User-Agent, so a customer can restrict their captcha traffic to the browsers their app supports. Also adds `os` and `browser` to the Redis split-query scalar field list. `SCALAR_USER_SCOPE_FIELDS` there was never updated when the OS dimension landed a week earlier, so an OS-only rule emitted no probe of its own and was reachable only via the `no-user-scope` fall-through — sharing that probe's candidate budget with genuine client-wide blocks.
Contributor
Author
|
Not ready for review — still watching CI. |
Contributor
Author
|
Verified end to end on a local stack (provider + portal + demo, Mongo/Redis in docker):
Also corrects a claim in the changeset: I'd written that the Redis index needs rebuilding on deploy. It does not — |
Keeps only what the code cannot say: why the classifier is duplicated rather than imported, why its branch order matters, why the request scope populates browser unconditionally, and what the split-query probe test is guarding.
HughParry
enabled auto-merge (squash)
September 1, 2026 16:01
HughParry
added a commit
that referenced
this pull request
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.