Fix spurious truncation of HREX swap stats #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proteneer
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is just a pair of states (K = 2), we add an identity move to the mixture of neighbor swap moves in HREX to prevent periodicity when the swap acceptance probability is close to 1.
Originally, the identity move was added regardless of the value of K, but we changed the logic in #1128 to only add it when K = 2, because the mechanism for periodicity that it's intended to work around can't occur for K > 2. But we neglected to wrap the corresponding truncation to remove the acceptance stats for the identity move in the same conditional, resulting in truncating acceptance stats for the first neighbor swap move when K > 2.
This PR fixes the issue and adds a test.