Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cf-edhoc and edhoc-rs #82

Merged
merged 5 commits into from
Feb 13, 2024
Merged

Update cf-edhoc and edhoc-rs #82

merged 5 commits into from
Feb 13, 2024

Conversation

actyp
Copy link
Member

@actyp actyp commented Feb 13, 2024

In order to overcome the failing tests, the edhoc-rs commit hash needed to be updated, which in turn required the update of the cf-edhoc library up to the latest version v23. So the changes are the following:

  • Added supported protocol versions up to v23, which is the only one that required some changes in MessageProtocolPersistent

  • Bumped the commit hash of cf-edhoc

  • Bumped the commit hash of edhoc-rs to the latest one, which uses the latest changes from v23 and updated the args files

  • Updated the saved model of server, which now contains one less state and updated the ci.yml

@actyp actyp self-assigned this Feb 13, 2024
@actyp actyp requested a review from kostis February 13, 2024 01:51
Copy link
Member

@kostis kostis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are OK.

On a second thought, I am wondering whether it would be better to use the tag 0.5.0 instead of the commit hash for edhoc-rs (since this corresponds to a release). I will let you decide.

@actyp
Copy link
Member Author

actyp commented Feb 13, 2024

Yes it may be better, so I

  • used the tag of edhoc-rs and
  • updated the setup_fuzzer.sh and setup_sul.sh scripts with a slightly more flexible name of the checkout variable (in case we want to use other means to checkout the git repos).

@kostis
Copy link
Member

kostis commented Feb 13, 2024

Looks good. Go ahead and merge this.

@actyp actyp merged commit ff0cc6c into main Feb 13, 2024
22 checks passed
@actyp actyp deleted the update-cf-edhoc-and-edhoc-rs branch February 13, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants