Backport binary proto serialization/deserialization changes and enable protobuf Editions #238
+10,617
−8,907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BinaryReader.readStringRequireUtf8 may be called by users (particularly the protobuf conformance suite) and therefore needs to visible after minification/google closure prop renaming. This change also fixes a type warning around something we assert is present.
Moving the conformance test runner out of the experimental directory and refreshing things so we can get a baseline for the current state of the repo. This does not exactly represent google-protobuf-3.21.4 because there was a missing @export annotation that prevents the tests from running correctly (i.e. function not found in optimized mode). This change also merges together the runner's main file and helper library for the sake of simplicity and uses node requires exclusively. We previously supported running conformance tests in browser mode, but I'm dropping it for the sake of getting things running.
dibenede
force-pushed
the
editions
branch
2 times, most recently
from
a3e197c to
8c50065
Compare
varomodt
reviewed
Jul 22, 2025
In order to prepare for protobuf editions support, we are backporting our binary serialization and deserialization libraries (and associated tests). The newer code includes several years worth of improvements that improve the overall conformance findings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.