Allow to keep default values in serialized JSON #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you send this PR to protobuf’s main repo?
…On Tue, Mar 17, 2020 at 6:20 AM Alexander Shiltcev ***@***.***> wrote:
We use Protobuf to define API endpoints and spotted surprising behavior -
items with default values are absent in the serialized JSON. It is uncommon
for PHP REST APIs to have parameters disappearing from response when
returned value is default one. This PR solves this problem without braking
default behavior.
I would like to hear your feedback on proposed solution. Thanks.
------------------------------
You can view, comment on, or merge this pull request online at:
#6
Commit Summary
- Allow to keep default values in serialized JSON
File Changes
- *M* README.md
<https://github.com/protocolbuffers/protobuf-php/pull/6/files#diff-04c6e90faac2675aa89e2176d2eec7d8>
(7)
- *M* src/Google/Protobuf/Internal/GPBWire.php
<https://github.com/protocolbuffers/protobuf-php/pull/6/files#diff-6d4f2e77838aaccbe4cc7a7a1370ad87>
(10)
- *M* src/Google/Protobuf/Internal/Message.php
<https://github.com/protocolbuffers/protobuf-php/pull/6/files#diff-e2ee323e57d24611a2b3e21edf4fd598>
(116)
Patch Links:
- https://github.com/protocolbuffers/protobuf-php/pull/6.patch
- https://github.com/protocolbuffers/protobuf-php/pull/6.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#6>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABHUPZO3YQURT3ONSAGGHP3RH52LVANCNFSM4LNNOPLQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use Protobuf to define API endpoints and spotted surprising behavior - items with default values are absent in the serialized JSON. It is uncommon for PHP REST APIs to have parameters disappearing from response when returned value is default one. This PR solves this problem without braking default behavior.
I would like to hear your feedback on proposed solution. Thanks.