add country-coder json [#44] #880
bdonsonar.yml
on: pull_request
Analyze with Sonar
1m 19s
Annotations
4 warnings
|
MINOR CODE_SMELL:
src/main/java/com/protomaps/basemap/feature/CountryCoder.java#L38
Reduce the total number of break and continue statements in this loop to use at most one.
rule: java:S135 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS135&rule_key=java%3AS135)
issue url: https://sonarcloud.io/project/issues?pullRequest=328&open=AZT5qHkTEwBQJQ99jiGv&id=protomaps_basemaps
|
|
CRITICAL CODE_SMELL:
src/main/java/com/protomaps/basemap/feature/CountryCoder.java#L41
Define a constant instead of duplicating this literal "geometry" 3 times.
rule: java:S1192 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS1192&rule_key=java%3AS1192)
issue url: https://sonarcloud.io/project/issues?pullRequest=328&open=AZT5qHkTEwBQJQ99jiGw&id=protomaps_basemaps
|
|
MAJOR CODE_SMELL:
src/main/java/com/protomaps/basemap/feature/CountryCoder.java#L92
Rename this variable to not match a restricted identifier.
rule: java:S6213 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS6213&rule_key=java%3AS6213)
issue url: https://sonarcloud.io/project/issues?pullRequest=328&open=AZT5qHkTEwBQJQ99jiGx&id=protomaps_basemaps
|
|
MAJOR CODE_SMELL:
src/main/java/com/protomaps/basemap/layers/Roads.java#L160
Either remove or fill this block of code.
rule: java:S108 (https://sonarcloud.io/organizations/protomaps/rules?open=java%3AS108&rule_key=java%3AS108)
issue url: https://sonarcloud.io/project/issues?pullRequest=328&open=AZT5qHnpEwBQJQ99jiGy&id=protomaps_basemaps
|