Clip tileset to a polygonal boundary #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdon
commented
Jan 9, 2025
tiles/src/main/java/com/protomaps/basemap/postprocess/Clip.java
Outdated
Show resolved
Hide resolved
bdon
commented
Jan 9, 2025
|
|
||
| public Clip(Stats stats, Geometry input) { | ||
| this.stats = stats; | ||
| var clipGeometry = latLonToWorldCoords(input).buffer(0.00001); |
There was a problem hiding this comment.
Maybe this should be configurable buffer size via arguments?
bdon
commented
Jan 9, 2025
tiles/src/main/java/com/protomaps/basemap/postprocess/Clip.java
Outdated
Show resolved
Hide resolved
bdon
commented
Jan 9, 2025
tiles/src/main/java/com/protomaps/basemap/postprocess/Clip.java
Outdated
Show resolved
Hide resolved
bdon
commented
Jan 9, 2025
bdon
commented
Jan 9, 2025
tiles/src/main/java/com/protomaps/basemap/postprocess/Clip.java
Outdated
Show resolved
Hide resolved
|
Do you store the clipping mask in world coordinates (web mercator x y of the 0/0/0 tile) or do you store it in tile coordinates? |
|
I saw you have a covering tiles mechanism. I think you could get rid of this by using an STRtree https://locationtech.github.io/jts/javadoc/org/locationtech/jts/index/strtree/STRtree.html and use the tile bounds as an envelope for querying |
* pass a GeoJSON feature polygon or multipolygon to clip the entire tileset. * output for country or city sized basemaps looks better when zoomed out. * implement an internal tiled index so there is minimal performance impact.
|
Results for small area in Monaco, expanding by 4/256 units:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #51
This is to address making non-global maps: for example, a map of a single continent, country, or city. The existing tooling has a path to doing this with
pmtiles extracton a planet file, but this has a downside: the output tileset is not clipped to the AOI (area of interest) and shows the entire detail of the original source tileset at lower zoom levels.Additionally, if the input OSM data has features that lie outside of the AOI, like oceans or roads, those extend beyond the boundary. This is not a fatal problem for many use cases, but we can do better in our tile generation program by clipping every feature to the AOI.
The challenges here are: