#962 Bulk connectors ops #3473
#962 Bulk connectors ops #3473
Conversation
Haarolean
added
type/enhancement
kafka-ui-react-app/src/components/Connect/List/BatchActionsBar.tsx
Outdated
Show resolved
Hide resolved
| > | ||
| Pause | ||
| </ActionCanButton> | ||
| <ActionCanButton |
There was a problem hiding this comment.
<ActionButton please check this component , because the <ActionCanButton is just so we would be able to use some very custom selectors together.
use <ActionButton and it has a permisson props , please check that.
so we will have a uniform way for doing the permission.
There was a problem hiding this comment.
ActionButton is only capable on checking permissions on one entity, but collection. I need either modify the way we operate permissions in ActionButton or use ActionCanButton or I can create new component ActionOnCollectionButton and implement those permissions use there. WDYT is the best way?
There was a problem hiding this comment.
@Mgrdich any thoughts here?
There was a problem hiding this comment.
I will think about it and get back to you.
| const link = await screen.findByRole('cell', {name: 'hdfs-source-connector'}); | ||
|
|
||
| await userEvent.click(link); | ||
| await waitFor(() => { |
There was a problem hiding this comment.
@Mgrdich Could you please take a look on this test? I'm struggling to fix it even though the link itself works when tested manually
There was a problem hiding this comment.
or @sasunprov maybe you'll have some time since you're assigned to the issue.
There was a problem hiding this comment.
@kamsharipova we'll take a look :)
There was a problem hiding this comment.
maybe it works when you run it on its own, because there are globals mock that are not being reset-ted normally in the upper describe block.
please check that and you can use beforeEach afterEach
kafka-ui-react-app/src/components/Connect/List/ConnectorCell.tsx
Outdated
Show resolved
Hide resolved
kamsharipova
force-pushed
the
bulk-connectors-ops
branch
from
0a6a961 to
19c0b29
Compare
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)