Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE: Controllers structure minor refactr #4110

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Conversation

iliax
Copy link
Contributor

@iliax iliax commented Aug 11, 2023

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Audit & access controll services moved to AbstractController

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@iliax iliax requested a review from a team as a code owner August 11, 2023 10:10
@github-actions github-actions bot added the status/triage Issues pending maintainers triage label Aug 11, 2023
@Haarolean Haarolean added scope/backend type/refactoring and removed status/triage Issues pending maintainers triage labels Aug 11, 2023
@Haarolean Haarolean added this to the 0.8 milestone Aug 11, 2023
@iliax iliax merged commit fa9547b into master Aug 11, 2023
@iliax iliax deleted the controllers_structure_refactor branch August 11, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants