Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common prefix for all application metrics #4177

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

iliax
Copy link
Contributor

@iliax iliax commented Aug 31, 2023

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Common prefix for all application metrics added to make it easier to distinguish kui metrics from other metrics, exposed by spring boot

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

…distinguish kui metrics from other metrics, exposed by spring boot
@iliax iliax requested a review from a team as a code owner August 31, 2023 09:00
@github-actions github-actions bot added the status/triage Issues pending maintainers triage label Aug 31, 2023
@Haarolean Haarolean added type/enhancement En enhancement to an already existing feature scope/backend and removed status/triage Issues pending maintainers triage labels Sep 5, 2023
@Haarolean Haarolean added this to the 0.8 milestone Sep 5, 2023
@Haarolean Haarolean merged commit 59584ed into master Sep 5, 2023
@Haarolean Haarolean deleted the application_metrics_common_prefix branch September 5, 2023 14:03
@Haarolean
Copy link
Contributor

@iliax thanks for your contribution! 😁

gimral pushed a commit to gimral/kafka-ui that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/backend type/enhancement En enhancement to an already existing feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants