Skip to content

Feature/topology visualizer contract #205 #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 24 commits into from

Conversation

Flyur
Copy link

@Flyur Flyur commented Jul 6, 2021

API contract for the stream topology visualization feature.
Please, review the data model for the API.

How Has This Been Tested? (put an "X" next to an item)

  • No need to
  • Manually(please, describe, when necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "X" next to an item, otherwise PR will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings(e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 6, 2021

SonarCloud Quality Gate failed.

Bug B 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 43 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Flyur
Copy link
Author

Flyur commented Jul 10, 2021

Simplified the data model for now - it contains information about the topology of only one application and without kafka connectors.
simple example of the json:

{
    "processorsNumber": null,
    "topicsNumber": null,
    "topology": {
        "adjacency": {
            "sub-topology 0": [
                "count-resolved-repartition"
            ],
            "count-resolved-repartition": [
                "sub-topology 1"
            ],
            "sub-topology 1": []
        },
        "nodes": {
            "sub-topology 0": {
                "name": "sub-topology 0",
                "type": "SUB_TOPOLOGY",
                "subTopology": {
                    "adjacency": {
                        "KSTREAM-SOURCE-0000000000": [
                            "KSTREAM-TRANSFORM-0000000001"
                        ],
                        "KSTREAM-TRANSFORM-0000000001": [
                            "KSTREAM-SINK-000000002"
                        ],
                        "KSTREAM-SINK-000000002": []
                    },
                    "nodes": {
                        "KSTREAM-SOURCE-0000000000": {
                            "name": "KSTREAM-SOURCE-0000000000",
                            "type": "SOURCE_PROCESSOR",
                            "topics": [
                                "inputTopic"
                            ]
                        },
                        "KSTREAM-TRANSFORM-0000000001": {
                            "name": "KSTREAM-TRANSFORM-0000000001",
                            "type": "PROCESSOR",
                            "stores": [
                                "store 1"
                            ]
                        },
                        "KSTREAM-SINK-000000002": {
                            "name": "KSTREAM-SINK-000000002",
                            "type": "SINK_PROCESSOR",
                            "topic": "count-resolved-repartition"
                        }
                    }
                }
            },
            "count-resolved-repartition": {
                "name": "count-resolved-repartition",
                "type": "TOPIC",
                "inputMessagesNumber": null,
                "outputMessagesNumber": null,
                "lag": null
            },
            "sub-topology 1": {
                "name": "sub-topology 1",
                "type": "SUB_TOPOLOGY",
                "subTopology": {
                    "adjacency": {
                        "KSTREAM-SOURCE-000000003": [
                            "KSTREAM-TRANSFORM-000000004"
                        ],
                        "KSTREAM-TRANSFORM-000000004": [
                            "KSTREAM-SINK-000000005"
                        ],
                        "KSTREAM-SINK-000000005": []
                    },
                    "nodes": {
                        "KSTREAM-SOURCE-000000003": {
                            "name": "KSTREAM-SOURCE-000000003",
                            "type": "SOURCE_PROCESSOR",
                            "topics": [
                                "count-resolved-repartition"
                            ]
                        },
                        "KSTREAM-TRANSFORM-000000004": {
                            "name": "KSTREAM-TRANSFORM-000000004",
                            "type": "PROCESSOR",
                            "stores": [
                                "store 2"
                            ]
                        },
                        "KSTREAM-SINK-000000005": {
                            "name": "KSTREAM-SINK-000000005",
                            "type": "SINK_PROCESSOR",
                            "topic": "streams-count-resolved"
                        }
                    }
                }
            }
        }
    }
}

Flyur added 2 commits July 11, 2021 01:24
# Conflicts:
#	kafka-ui-contract/src/main/resources/swagger/kafka-ui-api.yaml
@Flyur Flyur requested a review from germanosin July 10, 2021 22:47
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 54 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@germanosin
Copy link
Contributor

LGTM for contract, let's implement reading / parsing part

@Flyur
Copy link
Author

Flyur commented Jul 20, 2021

@germanosin should we merge it to unblock frontend?

Flyur added 2 commits August 18, 2021 19:49
# Conflicts:
#	kafka-ui-api/src/main/java/com/provectus/kafka/ui/config/ClustersProperties.java
#	kafka-ui-api/src/main/java/com/provectus/kafka/ui/exception/ErrorCode.java
#	kafka-ui-contract/src/main/resources/swagger/kafka-ui-api.yaml
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 93 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

# Conflicts:
#	kafka-ui-api/src/main/java/com/provectus/kafka/ui/config/ClustersProperties.java
@Haarolean Haarolean added this to the 0.4 milestone Oct 13, 2021
@IldarAlmakaev IldarAlmakaev self-assigned this Oct 13, 2021
@IldarAlmakaev IldarAlmakaev removed the request for review from GneyHabub October 13, 2021 14:31
@IldarAlmakaev IldarAlmakaev linked an issue Oct 13, 2021 that may be closed by this pull request
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 115 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Haarolean Haarolean removed this from the 0.4 milestone Oct 25, 2021
@Haarolean Haarolean marked this pull request as draft October 26, 2021 11:41
@Haarolean Haarolean requested review from germanosin and removed request for IldarAlmakaev and germanosin December 21, 2021 09:38
@Haarolean Haarolean added the type/feature A new feature label Dec 21, 2021
@Haarolean Haarolean closed this Feb 17, 2022
@workshur workshur deleted the feature/topology_visualizer_contract branch June 2, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kafka Stream Topology visualizer
4 participants