Feature/smartaccount#617
Open
arnabmitra wants to merge 5 commits into
Open
Conversation
Release v0.50.13-pio-1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes changes to the assumption that
GetSigningTxDataadapter in cosmos-sdk that SignerInfos always set a public key directly (i would argue only he signature should be used to derive the public key always.)Also for WebAuthn signatures, the public key can be derived in from signature itself,
and has no correlation to the address itself(as can be the case in normal cosmos signatures flows),
the signature is compared against the pubkey registered while webauthn key registration, Additionally this doesn't really seem to be used anywhere else and does not affect normal cosmos verification flows.
The risk of this change is low in my opinion since the flow is used to compare the hash of the entire cosmos tx with the signature provided by the authentication mechanism.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
-[X ] included the correct type prefix in the PR title
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change