Skip to content

Feature/smartaccount#617

Open
arnabmitra wants to merge 5 commits into
release-pio/v0.50.xfrom
feature/smartaccount
Open

Feature/smartaccount#617
arnabmitra wants to merge 5 commits into
release-pio/v0.50.xfrom
feature/smartaccount

Conversation

@arnabmitra

@arnabmitra arnabmitra commented Mar 28, 2025

Copy link
Copy Markdown

Description

This PR makes changes to the assumption that GetSigningTxData adapter in cosmos-sdk that SignerInfos always set a public key directly (i would argue only he signature should be used to derive the public key always.)

Also for WebAuthn signatures, the public key can be derived in from signature itself,
and has no correlation to the address itself(as can be the case in normal cosmos signatures flows),
the signature is compared against the pubkey registered while webauthn key registration, Additionally this doesn't really seem to be used anywhere else and does not affect normal cosmos verification flows.

The risk of this change is low in my opinion since the flow is used to compare the hash of the entire cosmos tx with the signature provided by the authentication mechanism.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

-[X ] included the correct type prefix in the PR title

  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • [X ] added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@arnabmitra arnabmitra marked this pull request as ready for review July 25, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant