Skip to content

fix: add proto compiler to Dockerfile instead of github action #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rromanowski-figure merged 2 commits into from
Jan 9, 2026
Merged

fix: add proto compiler to Dockerfile instead of github action #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c36edd6
fix: add proto compiler to Dockerfile instead of github action
rromanowski-figure Jan 9, 2026
240298d
add docker ignore file
rromanowski-figure Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions .dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# Build outputs
target/
**/target/

# OS files
.DS_Store
**/.DS_Store
Thumbs.db

# Git
.git/
.gitignore

# Documentation
docs/
**/*.md
!README.md

# CI/CD files
.github/

# Logs and temporary files
*.log
tmp/
.cache/

# Docker files
Dockerfile*
.dockerignore
3 changes: 0 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,6 @@ jobs:
asset_name: protos-${{ env.VERSION }}.zip
asset_content_type: application/octet-stream

- name: Install Protoc
uses: arduino/setup-protoc@v3

- name: Log in to GitHub Container Registry
uses: docker/login-action@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "object-store"
version = "1.0.0-alpha.1"
version = "1.0.0-alpha.2"
authors = ["Stephen Cirner <scirner@figure.com>"]
edition = "2024"

Expand Down
5 changes: 5 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
FROM rust:1.92-bookworm AS builder

# Install protobuf compiler
RUN apt-get update && \
apt-get install -y protobuf-compiler && \
rm -rf /var/lib/apt/lists/*

RUN rustup component add rustfmt

WORKDIR /usr/src/object-store
Expand Down