Skip to content

fix: Clean up multipart files from disk properly#147

Merged
rpatel-figure merged 3 commits into
mainfrom
ravipatel/sc-518539/cleanup-files-properly
Jun 25, 2026
Merged

fix: Clean up multipart files from disk properly#147
rpatel-figure merged 3 commits into
mainfrom
ravipatel/sc-518539/cleanup-files-properly

Conversation

@rpatel-figure

Copy link
Copy Markdown
Collaborator

Context

We recently noticed that deploys are accumulating a large number of temporary Spring multi-part files from the EOS file upload endpoint. We aren't cleaning up these file resources properly, and seemingly did not notice this until 2026 when the growing disk space finally caused an alert.

Changes

  • Ensure buffers and file parts are always cleaned up
  • Ensure Spring's in-memory size limit for multiparts (which when exceeded results in the part being written to disk) is configurable

@rpatel-figure rpatel-figure added patch Bug fixes or other non-breaking configuration changes fix Fixes a bug labels Jun 17, 2026
@github-actions github-actions Bot added the bug Something isn't working label Jun 17, 2026
@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown

Test Results

10 tests   10 ✅  3s ⏱️
 6 suites   0 💤
 6 files     0 ❌

Results for commit 39012ea.

♻️ This comment has been updated with latest results.

@rromanowski-figure rromanowski-figure left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@rpatel-figure rpatel-figure removed the bug Something isn't working label Jun 25, 2026
@rpatel-figure rpatel-figure merged commit 4e0f638 into main Jun 25, 2026
5 of 6 checks passed
@rpatel-figure rpatel-figure deleted the ravipatel/sc-518539/cleanup-files-properly branch June 25, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Fixes a bug patch Bug fixes or other non-breaking configuration changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants