Java 8 maintenance #234
Java 8 maintenance #234
Conversation
📝 WalkthroughWalkthroughThe pull request downgrades the version numbers in the changelog from 10.x.x to 9.x.x and makes minor formatting adjustments. In the Gradle build script, multiple dependency versions are updated (or downgraded), the Java language version is changed from 11 to 8, and a new test task ( Changes
Sequence Diagram(s)sequenceDiagram
participant B as Build Script
participant T as Task Registry
participant J as Java 11 Launcher
participant TE as Test Executor
B->>T: Register new task "testOn11"
T->>J: Configure task with Java 11 toolchain
J->>TE: Execute tests using Java 11 runtime
TE-->>J: Return test results
J-->>T: Report task completion
T-->>B: Finish build task execution
Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (18)
CHANGELOG.md(1 hunks)build.gradle(4 hunks)src/main/java/com/prowidesoftware/swift/constraints/BicConstraint.java(1 hunks)src/main/java/com/prowidesoftware/swift/constraints/BicValidator.java(1 hunks)src/main/java/com/prowidesoftware/swift/constraints/CountryConstraint.java(1 hunks)src/main/java/com/prowidesoftware/swift/constraints/CountryValidator.java(1 hunks)src/main/java/com/prowidesoftware/swift/constraints/CurrencyConstraint.java(1 hunks)src/main/java/com/prowidesoftware/swift/constraints/CurrencyValidator.java(1 hunks)src/main/java/com/prowidesoftware/swift/constraints/IbanConstraint.java(1 hunks)src/main/java/com/prowidesoftware/swift/constraints/IbanValidator.java(1 hunks)src/main/java/com/prowidesoftware/swift/model/AbstractSwiftMessage.java(1 hunks)src/main/java/com/prowidesoftware/swift/model/FileFormat.java(0 hunks)src/main/java/com/prowidesoftware/swift/model/MtSwiftMessage.java(1 hunks)src/main/java/com/prowidesoftware/swift/model/SwiftMessageNote.java(1 hunks)src/main/java/com/prowidesoftware/swift/model/SwiftMessageRevision.java(1 hunks)src/main/java/com/prowidesoftware/swift/model/SwiftMessageStatusInfo.java(1 hunks)src/test/java/com/prowidesoftware/swift/constraints/IbanValidatorTest.java(1 hunks)src/test/java/com/prowidesoftware/swift/model/field/FieldComponentLabelsCompatibilityTest.java(1 hunks)
💤 Files with no reviewable changes (1)
- src/main/java/com/prowidesoftware/swift/model/FileFormat.java
🧰 Additional context used
🧠 Learnings (1)
src/main/java/com/prowidesoftware/swift/model/AbstractSwiftMessage.java (1)
Learnt from: zubri
PR: prowide/prowide-core#190
File: src/main/java/com/prowidesoftware/swift/model/AbstractSwiftMessage.java:22-23
Timestamp: 2025-04-09T23:25:51.388Z
Learning: In the project, `javax.xml` classes from the JDK are acceptable to use for XML processing, and there's no need to migrate them to the `jakarta` namespace.
🧬 Code Graph Analysis (1)
src/main/java/com/prowidesoftware/swift/model/MtSwiftMessage.java (4)
src/main/java/com/prowidesoftware/swift/model/SwiftMessageNote.java (1)
Entity(29-103)src/main/java/com/prowidesoftware/swift/model/SwiftMessageRevision.java (1)
Entity(33-128)src/main/java/com/prowidesoftware/swift/model/SwiftMessageStatusInfo.java (1)
Entity(35-234)src/main/java/com/prowidesoftware/swift/model/AbstractSwiftMessage.java (1)
Entity(47-1429)
🪛 markdownlint-cli2 (0.17.2)
CHANGELOG.md
3-3: Heading levels should only increment by one level at a time
Expected: h2; Actual: h4
(MD001, heading-increment)
3-3: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
4-4: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
4-4: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
4-4: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
5-5: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
6-6: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
8-8: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
9-9: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
9-9: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
11-11: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
12-12: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
12-12: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
12-12: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
13-13: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
14-14: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
15-15: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
16-16: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
18-18: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
19-19: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
19-19: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
20-20: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
22-22: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
23-23: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
23-23: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
24-24: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
26-26: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
27-27: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
27-27: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
28-28: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
28-28: Bare URL used
null
(MD034, no-bare-urls)
29-29: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
30-30: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
32-32: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
33-33: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
33-33: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
34-34: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
35-35: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
37-37: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
38-38: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
38-38: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
39-39: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
40-40: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
42-42: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
43-43: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
43-43: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
45-45: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
46-46: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
46-46: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
47-47: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
48-48: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
48-48: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
50-50: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
51-51: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
51-51: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
53-53: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
54-54: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
54-54: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
55-55: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
57-57: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
58-58: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
58-58: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
59-59: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
61-61: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
62-62: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
62-62: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
64-64: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
65-65: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
65-65: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
66-66: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
68-68: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
69-69: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
69-69: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
71-71: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
72-72: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
72-72: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
74-74: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
75-75: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
75-75: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
77-77: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
78-78: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
78-78: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
80-80: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
81-81: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
81-81: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
82-82: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
84-84: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
85-85: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
85-85: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
86-86: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
88-88: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (java)
🔇 Additional comments (23)
src/main/java/com/prowidesoftware/swift/constraints/IbanValidator.java (1)
20-21: Switching Validation Imports to Java EE.
The change from using Jakarta validation imports to using thejavax.validationequivalents is appropriate for maintaining Java 8 compatibility while preserving the existing behavior.src/main/java/com/prowidesoftware/swift/constraints/IbanConstraint.java (1)
24-25: Update to Validation Annotation Imports.
Replacing the Jakarta validation annotations with theirjavax.validationcounterparts aligns with the overall back-porting objectives and does not impact the functionality of the constraint.src/main/java/com/prowidesoftware/swift/model/SwiftMessageNote.java (1)
19-19: JPA Import Update for Java 8 Compatibility.
Updating the import fromjakarta.persistence.*tojavax.persistence.*is correct and necessary for Java 8 environments. This modification keeps the persistence configuration consistent with the rest of the back-ported code.src/test/java/com/prowidesoftware/swift/constraints/IbanValidatorTest.java (1)
7-8: Test Imports Updated for Java 8 Compliance.
The adjustments to import statements forClockProviderandConstraintValidatorContext(switching tojavax.validation) ensure that the testing framework remains compatible with Java 8. All validation tests should continue to execute as expected.src/main/java/com/prowidesoftware/swift/model/SwiftMessageRevision.java (1)
18-22: Update to JPA Imports for Java 8.
Changing the persistence imports to usejavax.persistence—including the static import forFetchType.LAZY—is fully in line with the Java 8 back-porting effort. This ensures that the JPA annotations are correctly processed in a Java 8 environment while leaving the business logic unchanged.src/main/java/com/prowidesoftware/swift/constraints/CurrencyValidator.java (1)
19-20: Import changed from Jakarta to Java EE package.The import statements have been modified to use
javax.validationinstead ofjakarta.validation. This change aligns with the PR objective of back-porting to Java 8, as Jakarta EE packages were introduced in newer Java versions.src/main/java/com/prowidesoftware/swift/constraints/BicValidator.java (1)
20-21: Import changed from Jakarta to Java EE package.The import statements have been modified to use
javax.validationinstead ofjakarta.validation. This change is consistent with the pattern seen in other validation-related files and supports the Java 8 back-port objective.src/main/java/com/prowidesoftware/swift/model/MtSwiftMessage.java (1)
31-33: Import changed from Jakarta to Java EE package.The JPA annotation imports have been changed from
jakarta.persistencetojavax.persistence. This modification maintains consistency with the back-port to Java 8 objective, as Java 8 uses the olderjavaxnamespace for these persistence annotations.src/main/java/com/prowidesoftware/swift/constraints/CountryConstraint.java (1)
24-25: Import changed from Jakarta to Java EE package.The validation constraint import statements have been modified to use
javax.validationinstead ofjakarta.validation. This change maintains consistency with the other validation-related files and aligns with the Java 8 back-port objective.src/test/java/com/prowidesoftware/swift/model/field/FieldComponentLabelsCompatibilityTest.java (1)
62-63: Modified class instantiation method for Java 8 compatibility.Two changes have been made to the test code:
- Removed the generic wildcard (
<?>) from theClasstype- Changed from
c.getDeclaredConstructor().newInstance()to the simplerc.newInstance()The latter method is deprecated in Java 9 but works in Java 8, making this change consistent with the back-porting objective. Note that this method doesn't check for the accessibility of the constructor before invoking it, which was addressed in newer Java versions.
src/main/java/com/prowidesoftware/swift/model/SwiftMessageStatusInfo.java (2)
18-18: Import Update – JPA Package MigrationThe static import on line 18 has been updated to use
javax.persistence.FetchType.LAZYinstead of the Jakarta equivalent. This change is in line with the back-porting to Java 8 and ensures consistency with the project’s use of Java EE packages.
22-22: JPA Imports ReplacementThe import on line 22 now uses
javax.persistence.*instead of Jakarta’s version. This update properly aligns with the Java 8 maintenance goals and the broader transition across the code base.src/main/java/com/prowidesoftware/swift/constraints/CurrencyConstraint.java (1)
24-25: Validation Annotation Import UpdateThe imports for
ConstraintandPayloadhave been updated to use thejavax.validationpackage rather thanjakarta.validation. This change is consistent with the effort to back-port to Java 8.src/main/java/com/prowidesoftware/swift/constraints/CountryValidator.java (1)
19-20: Validation API Import UpdateThe modifications on lines 19–20 switch the imports for
ConstraintValidatorandConstraintValidatorContextfromjakarta.validationtojavax.validation. This update correctly supports the Java 8 environment and aligns with the overall migration strategy.src/main/java/com/prowidesoftware/swift/constraints/BicConstraint.java (1)
24-25: Validation Annotation TransitionThe change on lines 24–25 updates the imports for
ConstraintandPayloadto usejavax.validationinstead of their Jakarta counterparts. This ensures uniformity in the validation framework and is appropriate for Java 8 maintenance.src/main/java/com/prowidesoftware/swift/model/AbstractSwiftMessage.java (1)
29-30: Persistence & XML Binding Imports UpdateThe modifications update the import statements on lines 29 and 30 to use
javax.persistence.*andjavax.xml.bind.annotation.XmlTransient. This replacement of Jakarta packages with their Java EE equivalents supports Java 8 back-porting. Additionally, note that usingjavax.xml.bindis appropriate for Java 8 (as confirmed by long-term memory notes from zubri).CHANGELOG.md (1)
3-7: Version Number Downgrade Verification
The version headings have been updated from the 10.x.x scheme to 9.x.x (e.g. "#### 9.5.5 - December 2024"). Please confirm that the downgrade accurately reflects the intended back-port changes and overall versioning strategy.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
3-3: Heading levels should only increment by one level at a time
Expected: h2; Actual: h4(MD001, heading-increment)
3-3: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
4-4: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
4-4: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
4-4: Lists should be surrounded by blank lines
null(MD032, blanks-around-lists)
5-5: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
6-6: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
build.gradle (6)
7-10: Dependency and Plugin Version Updates
The buildscript dependencies have been updated as follows:
•gradle-quality-plugin: upgraded to 5.0.0
•axion-release-plugin: downgraded to 1.14.5 (with a note that version 15.* requires Java 11)
•publish-plugin: updated to 2.0.0
•spotless-plugin-gradle: downgraded to 6.13.0
These changes help maintain Java 8 compatibility and align with the back-port objectives.
40-42: Java Toolchain Configuration
The Java toolchain is now configured to use Java 8 (languageVersion set to 8), which fulfills the PR’s back-port to Java 8. Please verify that all parts of the codebase remain compatible with Java 8 under this setting.
60-63: Switch from Jakarta EE to Java EE APIs
The compile-time dependencies have been switched from Jakarta EE to their Java EE counterparts:
•jakarta.persistence:jakarta.persistence-api:3.1.0→javax.persistence:javax.persistence-api:2.2
•jakarta.xml.bind:jakarta.xml.bind-api:4.0.2→javax.xml.bind:jaxb-api:2.3.1
•jakarta.validation:jakarta.validation-api:3.1.0→javax.validation:validation-api:2.0.1.Final
This modification is critical for ensuring compatibility with Java 8. Please verify that all related runtime dependencies and code references are updated consistently.
64-66: Test Dependencies Update
The test dependencies have been adjusted accordingly (e.g. usingjavax.validation:validation-api:2.0.1.Finalandjavax.persistence:javax.persistence-api:2.2). Confirm that these align with the compile-only dependencies and that all tests run successfully under Java 8.
81-91: Manifest Attributes Update
The manifest attributes are now dynamically populated usingproject.sourceCompatibilityandproject.targetCompatibility(along with other runtime details). This dynamic approach aids in maintaining consistency across builds. Please confirm that these properties are defined as expected in the project settings so that the manifest accurately reflects the build environment.
273-278:❓ Verification inconclusive
New Test Task for Java 11
A new test task,testOn11, has been introduced to run tests using Java 11 via the toolchain. This addition facilitates cross-version testing; however, given that the default toolchain is set to Java 8 (per the PR objective), ensure that the tests remain applicable and that any Java 11–specific behavior is well documented.
Action Required: Verify Documentation and Cross-Version Test Compatibility
The new
testOn11task added tobuild.gradle(lines 273–278) sets up a Java 11 testing environment via the toolchain, which supports our cross-version testing objective. As the default toolchain remains set to Java 8, please ensure that:
- Tests run consistently under both Java 8 and Java 11.
- Any Java 11–specific behavior is clearly documented so future maintainers understand potential discrepancies.
| * Update apache-commons-lang3 from 3.14.0 to 3.17.0 fixing derived apache-text dependency vulnerabilities | ||
| * Minor thread safety fix in the `PropertyLoaded` class, used by the `SafeXmlUtils` | ||
| * Gradle wrapper update to 8.12 | ||
|
|
||
| #### 10.2.4 - November 2024 | ||
| #### 9.5.4 - November 2024 | ||
| * Rolling back SHA-256 checksum algorithm to MD5 in the MT message model | ||
|
|
||
| #### 10.2.3 - November 2024 | ||
| #### 9.5.3 - November 2024 | ||
| * (PW-2040) Updated the BBAN validation data file to the IBAN REGISTRY Jul 2024 release | ||
| * (PW-2006) Fixed `getMUR` and `setMUR` in `SwiftMessage` to prioritize field 108 in block 4 over block 3 for system messages (category 0) | ||
| * Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas | ||
| * Added `isSystemMessage()` to SwiftMessage to check if the message is a category 0 message (010. 011, etc...) | ||
| * Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas | ||
|
|
||
| #### 10.2.2 - October 2024 | ||
| #### 9.5.2 - October 2024 | ||
| * Added new `FieldEnum` with all the available field names | ||
| * Code security improvements as per CodeQL recommendations | ||
|
|
||
| #### 10.2.1 - June 2024 | ||
| #### 9.5.1 - June 2024 | ||
| * (PW-1913) Added IBAN validation for Egypt local account structure | ||
| * Restore deprecated method in MT210 class |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Markdown Formatting Considerations
Several markdownlint warnings (e.g. heading levels, blank lines around headings/lists, and unordered list indentation) have been reported. Although these are not functional issues, aligning the file’s formatting with our markdown guidelines would improve readability. Consider addressing these formatting issues in a future update if they are not within the scope of this back-port.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
4-4: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
4-4: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
4-4: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
5-5: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
6-6: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
8-8: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
9-9: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
9-9: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
11-11: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
12-12: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
12-12: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
12-12: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
13-13: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
14-14: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
15-15: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
16-16: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
18-18: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
19-19: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
19-19: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
20-20: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
22-22: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
23-23: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
23-23: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
24-24: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
| setSrcDirs(['src/main/java', 'src/generated/java']) | ||
| } | ||
| } | ||
| sourceSets.main.java.srcDirs = ['src/main/java', 'src/generated/java'] |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Source Sets Configuration Update
The main Java source directories are now explicitly set to include both src/main/java and src/generated/java. Please ensure that the generated sources are produced in the expected location and that this change does not affect the compilation process unexpectedly.
There was a problem hiding this comment.
Actionable comments posted: 5
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
CHANGELOG.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
CHANGELOG.md
3-3: Heading levels should only increment by one level at a time
Expected: h2; Actual: h4
(MD001, heading-increment)
3-3: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
4-4: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
4-4: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
6-6: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
7-7: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
7-7: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
7-7: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
8-8: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
9-9: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
11-11: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
12-12: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
12-12: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
14-14: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
15-15: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
15-15: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
15-15: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
16-16: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
17-17: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
18-18: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
19-19: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
21-21: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
22-22: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
22-22: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
23-23: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
25-25: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
26-26: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
26-26: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
27-27: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
29-29: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
30-30: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
30-30: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
31-31: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
31-31: Bare URL used
null
(MD034, no-bare-urls)
32-32: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
33-33: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
35-35: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
36-36: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
36-36: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
37-37: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
38-38: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
40-40: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
41-41: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
41-41: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
42-42: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
43-43: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
45-45: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
46-46: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
46-46: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
48-48: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
49-49: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
49-49: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
50-50: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
51-51: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
51-51: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
53-53: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
54-54: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
54-54: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
56-56: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
57-57: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
57-57: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
58-58: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
60-60: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
61-61: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
61-61: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
62-62: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
64-64: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
65-65: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
65-65: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
67-67: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
68-68: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
68-68: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
69-69: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
71-71: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
72-72: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
72-72: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
74-74: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
75-75: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
75-75: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
77-77: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
78-78: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
78-78: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
80-80: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
81-81: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
81-81: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
83-83: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
84-84: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
84-84: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
85-85: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
87-87: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
88-88: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
88-88: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
89-89: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
91-91: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (java)
🔇 Additional comments (18)
CHANGELOG.md (18)
3-5: Version update for SNAPSHOT release (9.5.6)
This header has been updated to “#### 9.5.6 - SNAPSHOT” as part of the back-porting changes. The version downgrade is in line with the PR’s objective.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
3-3: Heading levels should only increment by one level at a time
Expected: h2; Actual: h4(MD001, heading-increment)
3-3: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
4-4: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
4-4: Lists should be surrounded by blank lines
null(MD032, blanks-around-lists)
6-10: Version update for December 2024 (9.5.5)
The entry “#### 9.5.5 - December 2024” now reflects the update with dependency fixes (apache-commons‑lang3 update, thread safety fix inPropertyLoaded, and a Gradle wrapper update). The changes appear consistent with the intended downgrade.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
6-6: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
7-7: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
7-7: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
7-7: Lists should be surrounded by blank lines
null(MD032, blanks-around-lists)
8-8: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
9-9: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
11-13: Version update for November 2024 (9.5.4)
The header “#### 9.5.4 - November 2024” has been updated accordingly. No issues detected.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
11-11: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
12-12: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
12-12: Lists should be surrounded by blank lines
null(MD032, blanks-around-lists)
21-24: Version update for October 2024 (9.5.2) – New FieldEnum and Security Enhancements
The release entry now adds the newFieldEnumand mentions code security improvements. It would be beneficial to ensure that these new features are properly covered by tests and documented elsewhere in the repository.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
21-21: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
22-22: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
22-22: Lists should be surrounded by blank lines
null(MD032, blanks-around-lists)
23-23: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
25-28: Version update for June 2024 (9.5.1) – IBAN Validation and Deprecated Method Restoration
This update notes the addition of IBAN validation for Egypt local account structures and the restoration of a deprecated method in the MT210 class. Please confirm that the re‑introduction of the deprecated method does not lead to unwanted side effects.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
25-25: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
26-26: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
26-26: Lists should be surrounded by blank lines
null(MD032, blanks-around-lists)
27-27: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
35-39: Version update for May 2024 (9.4.16) – NarrativeFragment Addition
The changes note the addition of theNarrativeFragmentclass, a fix in SwiftMessage’s PDE getter, and a helper method for field 37K. These enhancements look appropriate; just ensure that the new class and methods are adequately documented and unit tested.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
35-35: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
36-36: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
36-36: Lists should be surrounded by blank lines
null(MD032, blanks-around-lists)
37-37: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
38-38: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
40-44: Version update for March 2024 (9.4.15) – Narrative Resolver and Validator Updates
This entry updates the narrative resolver (format 2) to allow empty values, updates validators for BIC, country, and currency constraints (utilizing i18n‑compatible messages), and deprecates unnecessary methods inSafeXmlUtils. Confirm that these changes maintain backward compatibility.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
40-40: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
41-41: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
41-41: Lists should be surrounded by blank lines
null(MD032, blanks-around-lists)
42-42: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
43-43: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
45-47: Version update for December 2023 (9.4.14) – Dynamic Component Labeling
The update now modifies thegetComponentLabel(component)method in Field59F to be dynamic. Make sure that the new dynamic behavior is reflected consistently across user‐interfaces or other integrations that rely on these labels.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
45-45: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
46-46: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
46-46: Lists should be surrounded by blank lines
null(MD032, blanks-around-lists)
48-52: Version update for November 2023 (9.4.13) – Pattern Fixes and DistinguishedName Addition
This entry addresses fixes for validation/parse patterns in field 29O, MT306 changes, and adds a new DistinguishedName builder to encapsulate BIC branch name logic. The improvements appear well‐motivated; verifying consistency with pre‑existing logic is recommended.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
48-48: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
49-49: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
49-49: Lists should be surrounded by blank lines
null(MD032, blanks-around-lists)
50-50: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
51-51: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
51-51: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
53-55: Version update for November 2023 (9.4.12) – Validation Pattern Corrections
The update fixes the validation patterns in fields 14[H,K,L,M,N,O] and 29J. It is important to verify that the new patterns still accept valid inputs and reject invalid ones as expected.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
53-53: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
54-54: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
54-54: Lists should be surrounded by blank lines
null(MD032, blanks-around-lists)
60-63: Version update for October 2023 (9.4.10) – Field 31R and Additional Getters
The entry updates Field 31R to support two date components and adds getters for fields 36B and 36D in MT543. Confirm that these API additions are backward compatible and do not impact existing functionalities.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
60-60: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
61-61: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
61-61: Lists should be surrounded by blank lines
null(MD032, blanks-around-lists)
62-62: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
67-70: Version update for October 2023 (9.4.8) – Enhanced Extraction Methods and JSON Support
The entry introduces default methods for sender, receiver, and identifier extraction and adds JSON support to theFileFormatenumeration. These API additions appear solid; ensure that their usage is well documented.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
67-67: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
68-68: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
68-68: Lists should be surrounded by blank lines
null(MD032, blanks-around-lists)
69-69: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
71-73: Version update for September 2023 (9.4.7) – Field 44J Parsing Improvement
The fix for Field 44J improves its parse and getValue methods to properly handle multiline content. This should enhance data preservation.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
71-71: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
72-72: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
72-72: Lists should be surrounded by blank lines
null(MD032, blanks-around-lists)
77-79: Version update for August 2023 (9.4.5) – Field 44J Parsing Refinement
The update addresses issues in Field 44J’s parse and getValue logic. Verify that this fix integrates smoothly with earlier implementations of Field 44J functionality.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
77-77: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
78-78: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
78-78: Lists should be surrounded by blank lines
null(MD032, blanks-around-lists)
80-82: Version update for August 2023 (9.4.4) – Field 44J Format Adjustment
The formatting of Field 44J has been adjusted to allow multiline values. It is advisable to test legacy inputs to ensure that no regressions occur.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
80-80: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
81-81: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
81-81: Lists should be surrounded by blank lines
null(MD032, blanks-around-lists)
83-86: Version update for July 2023 (9.4.3) – 31R Deprecation Removal and Payload Trimming
The removal of the deprecation in the field 31R model and the introduction of trimming for original payload strings inAbstractSwiftMessageare significant. Please confirm these changes do not adversely affect any client code or tests.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
83-83: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
84-84: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
84-84: Lists should be surrounded by blank lines
null(MD032, blanks-around-lists)
85-85: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
87-90: Version update for June 2023 (9.4.2) – Padding and Pattern Fixes
This change removes unnecessary padding in sender/receiver fields and fixes pattern issues in Field44J. Because such format changes can impact external integrations, thorough testing is recommended.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
87-87: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
88-88: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
88-88: Lists should be surrounded by blank lines
null(MD032, blanks-around-lists)
89-89: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
91-93: Version update for June 2023 (9.4.1) – Correcting Missing Pattern in Field44J
The missing pattern in Field44J has now been fixed. This straightforward correction should be verified to ensure that pattern matching works as expected in all scenarios.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
91-91: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
92-92: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
92-92: Lists should be surrounded by blank lines
null(MD032, blanks-around-lists)
| #### 9.4.6 - September 2023 | ||
| * Added support for an optional `pw-swift-core.properties` to customize the behavior of the SafeXmlUtils class | ||
|
|
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Version update for September 2023 (9.4.6) – Optional Properties Support
The addition of support for an optional pw‑swift‑core.properties file to customize the behavior of SafeXmlUtils is a useful feature. Please update the associated documentation to guide users on how to leverage this property file.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
74-74: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
75-75: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
75-75: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
| #### 9.4.11 - November 2023 | ||
| * (PW-1695) Fixed a stack overflow in the fields fromJson implementation when a malformed JSON input contains empty field names | ||
| * (PW-1688) Added missing field labels for SRU2023 changes in the pw_swift_*.properties file | ||
|
|
There was a problem hiding this comment.
Version update for November 2023 (9.4.11) – Critical JSON Parsing Fix
A stack overflow issue in the fromJson implementation for fields, as well as missing field labels for SRU2023 changes, have been addressed here. This fix is critical; ensure thorough regression testing is performed.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
56-56: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
57-57: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
57-57: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
58-58: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
| #### 9.5.0 - May 2024 | ||
| * SWIFT Standard release update 2024 (live 16 November 2025) | ||
| * Yearly revision of deprecation phase (see https://dev.prowidesoftware.com/SRU2024/getting-started/deprecation/) | ||
| * Dependency update: commons-lang3 -> 3.14.0 | ||
| * Dependency update: gson -> 2.11.0 | ||
| * Dependency update: commons-lang3 -> 3.14.0' | ||
| * Dependency update: gson -> 2.11.0' | ||
|
|
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Version update for May 2024 (9.5.0) – SWIFT Release, Deprecation Revision, and Dependency Updates
The entry specifies the SWIFT Standard update and a yearly deprecation phase revision. Notably, the dependency updates for commons-lang3 and gson on lines 32 and 33 include trailing apostrophes (e.g. “3.14.0'”). Please review these for potential typos.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
29-29: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
30-30: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
30-30: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
31-31: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
31-31: Bare URL used
null
(MD034, no-bare-urls)
32-32: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
33-33: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
| #### 9.5.3 - November 2024 | ||
| * (PW-2040) Updated the BBAN validation data file to the IBAN REGISTRY Jul 2024 release | ||
| * (PW-2006) Fixed `getMUR` and `setMUR` in `SwiftMessage` to prioritize field 108 in block 4 over block 3 for system messages (category 0) | ||
| * Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas | ||
| * Added `isSystemMessage()` to SwiftMessage to check if the message is a category 0 message (010. 011, etc...) | ||
| * Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas | ||
|
|
There was a problem hiding this comment.
Version update for November 2024 (9.5.3) – Duplicate Entry Warning
The entry “#### 9.5.3 - November 2024” shows two identical bullet points for “Added new MtSequenceEnum with all the available inner sequences of specific MT schemas” (on lines 17 and 19). Please verify whether the duplication is intentional or if one needs to be removed to avoid redundancy.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
14-14: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
15-15: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
15-15: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
15-15: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
16-16: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
17-17: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
18-18: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
19-19: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
| #### 9.4.9 - October 2023 | ||
| * (PW-1659) Field 24G deprecated Name and Address for Narrative | ||
|
|
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Version update for October 2023 (9.4.9) – Deprecation Notice for Field 24G
This update deprecates “Name and Address” in Field 24G for Narrative. It would be useful to document the migration path for users affected by this change.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
64-64: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
65-65: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
65-65: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
CHANGELOG.md (1)
34-35:⚠️ Potential issueFix trailing apostrophes in version updates.
Lines 34 and 35 include stray apostrophes after the version numbers. These should be removed for consistency:- * Dependency update: commons-lang3 -> 3.14.0' + * Dependency update: commons-lang3 -> 3.14.0 - * Dependency update: gson -> 2.11.0' + * Dependency update: gson -> 2.11.0🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
34-34: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
35-35: Unordered list indentation
Expected: 0; Actual: 2(MD007, ul-indent)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
CHANGELOG.md(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
CHANGELOG.md
3-3: Heading levels should only increment by one level at a time
Expected: h2; Actual: h4
(MD001, heading-increment)
3-3: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
4-4: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
4-4: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
5-5: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
6-6: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
8-8: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
9-9: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
9-9: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
9-9: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
10-10: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
11-11: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
13-13: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
14-14: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
14-14: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
16-16: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
17-17: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
17-17: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
17-17: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
18-18: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
19-19: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
20-20: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
21-21: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
23-23: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
24-24: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
24-24: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
25-25: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
27-27: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
28-28: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
28-28: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
29-29: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
31-31: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
32-32: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
32-32: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
33-33: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
33-33: Bare URL used
null
(MD034, no-bare-urls)
34-34: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
35-35: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
37-37: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
38-38: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
38-38: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
39-39: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
40-40: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
42-42: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
43-43: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
43-43: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
44-44: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
45-45: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
47-47: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
48-48: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
48-48: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
50-50: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
51-51: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
51-51: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
52-52: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
53-53: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
53-53: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
55-55: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
56-56: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
56-56: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
58-58: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
59-59: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
59-59: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
60-60: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
62-62: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
63-63: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
63-63: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
64-64: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
66-66: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
67-67: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
67-67: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
69-69: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
70-70: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
70-70: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
71-71: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
73-73: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
74-74: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
74-74: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
76-76: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
77-77: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
77-77: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
79-79: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
80-80: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
80-80: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
82-82: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
83-83: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
83-83: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
85-85: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
86-86: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
86-86: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
87-87: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
89-89: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
90-90: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
90-90: Lists should be surrounded by blank lines
null
(MD032, blanks-around-lists)
91-91: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
93-93: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (java)
🔇 Additional comments (1)
CHANGELOG.md (1)
3-3: Review: Version headings updated appropriately.
All CHANGELOG version headings have been consistently downgraded to the 9.x.x series to align with the Java 8 back-port objectives, and the chronological order (April 2025 → June 2023) looks correct.Also applies to: 8-8, 13-13, 16-16, 23-23, 27-27, 31-31, 37-37, 43-43, 47-47, 51-51, 56-56, 59-59, 63-63, 67-67, 70-70, 74-74, 77-77, 80-80, 83-83, 86-86, 89-89, 93-93
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
3-3: Heading levels should only increment by one level at a time
Expected: h2; Actual: h4(MD001, heading-increment)
3-3: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below(MD022, blanks-around-headings)
| * (PW-2040) Updated the BBAN validation data file to the IBAN REGISTRY Jul 2024 release | ||
| * (PW-2006) Fixed `getMUR` and `setMUR` in `SwiftMessage` to prioritize field 108 in block 4 over block 3 for system messages (category 0) | ||
| * Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas | ||
| * Added `isSystemMessage()` to SwiftMessage to check if the message is a category 0 message (010. 011, etc...) | ||
| * Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas |
There was a problem hiding this comment.
Remove duplicated entry.
The bullet "* Added new MtSequenceEnum with all the available inner sequences of specific MT schemas" appears twice in the 9.5.3 section (lines 19 and 21). Please remove the redundant line at line 21 to avoid confusion.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
21-21: Unordered list indentation
Expected: 0; Actual: 2
(MD007, ul-indent)
Back-port to Java 8
Summary by CodeRabbit
These improvements bolster overall stability and compatibility without altering core functionality.