Skip to content

[BFW-7619]prusa link: Allow long filenames on item download from Prusa Link#4598

Open
bkerler wants to merge 1 commit intoprusa3d:masterfrom
bkerler:prusalink_long_filename
Open

[BFW-7619]prusa link: Allow long filenames on item download from Prusa Link#4598
bkerler wants to merge 1 commit intoprusa3d:masterfrom
bkerler:prusalink_long_filename

Conversation

@bkerler
Copy link

@bkerler bkerler commented Apr 13, 2025

This solves issue #4476, which on download of previously long filename files will truncate the filename to short filenames via Prusa Link.

@3d-gussner
Copy link
Collaborator

@bkerler Please verify if that is still an issue with FW 6.2.4, as I wrote in the related issue I was not able to reproduce it.

BTW the PR failed in the unit test.

@bkerler
Copy link
Author

bkerler commented Jul 9, 2025

@3d-gussner sure, will try and report back.

@3d-gussner
Copy link
Collaborator

@3d-gussner sure, will try and report back.

Thanks

@bkerler
Copy link
Author

bkerler commented Jul 13, 2025

@3d-gussner Yep, tested and bug is still there:

image

@bkerler
Copy link
Author

bkerler commented Jul 13, 2025

Also confirmed that the bug also exists for latest 6.4.0 RC for Core One, not just MK4S

@bkerler
Copy link
Author

bkerler commented Jul 13, 2025

@bkerler Please verify if that is still an issue with FW 6.2.4, as I wrote in the related issue I was not able to reproduce it.

BTW the PR failed in the unit test.

The unit tests fails because the nhttp test uses sys/dirent.h instead of libsysbase/dirent.h which it should refer to. It was "quickfixed" in tests/gui/lazyfilelist/dirent.h but couldn't figure out anything similar for nhttp. It's less an issue of my PR but an issue with linkage/includes in the test itself.

@bkerler bkerler force-pushed the prusalink_long_filename branch from a1dc631 to 3e12bc2 Compare July 13, 2025 16:05
@bkerler
Copy link
Author

bkerler commented Jul 13, 2025

Instead of pointing to the updated dirent structure of libsysbase, I'm using the dirent_lfn instead which seems to do the trick.

@3d-gussner
Copy link
Collaborator

@bkerler Thanks. I still have FW6.2.4+8909 on my MK4 and can't reproduce this.
PrusaSlicer default cylinder

  • Slice and download file Shape-Cylinder_0.4n_0.2mm_PLA_MK4IS_1d0h42m.bgcode to my computer.
  • Upload to PrusaLink Shape-Cylinder_0.4n_0.2mm_PLA_MK4IS_1d0h42m.bgcode.
  • Download from PrusaLink to my Ubuntu Shape-Cylinder_0.4n_0.2mm_PLA_MK4IS_1d0h42m.bgcode. ✔️

Test PrusaSlicer with direct upload to PL

  • Slice with physical printer profile to PrusaLink and upload Shape-Cylinder_0.4n_0.2mm_PLA_MK4IS_1d0h42m_PL.bgcode.
  • Download from PrusaLink to my Ubuntu Shape-Cylinder_0.4n_0.2mm_PLA_MK4IS_1d0h42m_PL.bgcode ✔️

Test PrusaSlicer with direct uplod to PC

  • Slice with physical printer profile to PrusaConnect and upload Shape-Cylinder_0.4n_0.2mm_PLA_MK4IS_1d0h42m_PC.bgcode.
  • After waiting PC to send the complete file to PL I can download from PrusaLink to my Ubuntu Shape-Cylinder_0.4n_0.2mm_PLA_MK4IS_1d0h42m_PC.bgcode. ✔️

This is so strange that you have the issue and I don't.

@bkerler
Copy link
Author

bkerler commented Jul 17, 2025

@3d-gussner I think you also have this issue, but you are clicking on the wrong download field.

  1. Select Projects.
  2. Click on the filename. Do NOT click on the download icon.
  3. Now click on the big "Download" button.
  4. Filename will be 8+3 ext instead of long filename

If you directly click on the download icon and not on the filename and then download, the filename is of long format.

@3d-gussner
Copy link
Collaborator

@bkerler Thanks for the hint. Yes I can confirm, that the BIG DOWNLOAD button has the 8.3 filename.

The small download icon in Storage page works correctly.

@3d-gussner 3d-gussner changed the title prusa link: Allow long filenames on item download from Prusa Link [BFW-7619]prusa link: Allow long filenames on item download from Prusa Link Aug 15, 2025
Signed-off-by: Bjoern Kerler <info@revskills.de>
@bkerler bkerler force-pushed the prusalink_long_filename branch from 3e12bc2 to 78bb2f8 Compare December 7, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants