[BFW-7619]prusa link: Allow long filenames on item download from Prusa Link#4598
[BFW-7619]prusa link: Allow long filenames on item download from Prusa Link#4598bkerler wants to merge 1 commit intoprusa3d:masterfrom
Conversation
01f0bd9 to
a1dc631
Compare
|
@bkerler Please verify if that is still an issue with FW 6.2.4, as I wrote in the related issue I was not able to reproduce it. BTW the PR failed in the unit test. |
|
@3d-gussner sure, will try and report back. |
Thanks |
|
@3d-gussner Yep, tested and bug is still there:
|
|
Also confirmed that the bug also exists for latest 6.4.0 RC for Core One, not just MK4S |
The unit tests fails because the nhttp test uses sys/dirent.h instead of libsysbase/dirent.h which it should refer to. It was "quickfixed" in tests/gui/lazyfilelist/dirent.h but couldn't figure out anything similar for nhttp. It's less an issue of my PR but an issue with linkage/includes in the test itself. |
a1dc631 to
3e12bc2
Compare
|
Instead of pointing to the updated dirent structure of libsysbase, I'm using the dirent_lfn instead which seems to do the trick. |
|
@bkerler Thanks. I still have FW6.2.4+8909 on my MK4 and can't reproduce this.
Test PrusaSlicer with direct upload to PL
Test PrusaSlicer with direct uplod to PC
This is so strange that you have the issue and I don't. |
|
@3d-gussner I think you also have this issue, but you are clicking on the wrong download field.
If you directly click on the download icon and not on the filename and then download, the filename is of long format. |
|
@bkerler Thanks for the hint. Yes I can confirm, that the BIG DOWNLOAD button has the 8.3 filename. The small download icon in Storage page works correctly. |
Signed-off-by: Bjoern Kerler <info@revskills.de>
3e12bc2 to
78bb2f8
Compare

This solves issue #4476, which on download of previously long filename files will truncate the filename to short filenames via Prusa Link.