Skip to content

Restore spreadCycle in G28#4647

Open
espr14 wants to merge 146 commits intoprusa3d:masterfrom
espr14:patch-5
Open

Restore spreadCycle in G28#4647
espr14 wants to merge 146 commits intoprusa3d:masterfrom
espr14:patch-5

Conversation

@espr14
Copy link
Contributor

@espr14 espr14 commented May 11, 2025

G28 can switch to stealthChop but did not revert the changes.

vorner and others added 30 commits January 3, 2025 14:27
If we receive a stray chunk (leftover from an aborted transfer), don't
panic and kill the connection, just blackhole it silently and keep the
connection. Creating new connections is expensive.

BFW-6522.
(In websocket mode) update the download backup file before going to
process a command; that way the command sees as fresh data of the file
as possible and also, if it takes a long time / gets stuck, the other
threads get an update.

BFW-6428.
In addition to updating every 10s, make sure to also update every X
bytes transfered, so we don't lose as much and have higher chance to
show the preview sooner.

BFW-6428.
It turns out copy-pasting iX config file has its flaws.

BFW-6536
This is an improved ramming sequence from the Slicer team.

BFW-6536
This fixes CORE One missing M260 and M261 support.

BFW-6546
Testers were complaining that it's impossible to put out the print bed on aborted print.

BFW-6551
The user needs to be clean out the purged filament easily.

BFW-6551
and get rid of dependency on danol.cz
BFW-6420

(cherry picked from commit a4ab096d47f006a9328d54fc7597af698cc603bd)
The inject queue is not equipped to handling non-constexpr strings at the moment.
This commit ensures that we're only passing in literals.
Only the construction from the const char* has to be consteval, rest can be only constexpr
ConstexprString was previously okay when you passed him a buffer whose pointer was known at compile time, but contents were runtime - this change prevents that.
Tomcus and others added 26 commits January 24, 2025 13:09
This fixes a regression introduced in 636c23f

BFW-6680
subrepo:
  subdir:   "lib/Prusa-Error-Codes"
  merged:   "6fa23d43d5"
upstream:
  origin:   "[email protected]:prusa3d/Prusa-Error-Codes.git"
  branch:   "master"
  commit:   "6fa23d43d5"
git-subrepo:
  version:  "0.4.9"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "cce3d93"
git subrepo pull ./lib/Prusa-Error-Codes
Last minute product decisions are the best.

BFW-6695
The macOS build includes a `.tar.xzg` file, which 1bfe80a does not
properly handle. This simply adds this extension to the list which
should be extracted with tar instead of zip.
G28 can switch to stealthChop but did not revert the changes.
@bkerler
Copy link

bkerler commented May 28, 2025

Hi ! Can you please explain why this is needed ?

@espr14
Copy link
Contributor Author

espr14 commented May 28, 2025

  1. Either Original Prusa printers use stealthChop all the time (XY) so there's no reason to add extra code that sets stealthChop again. M569 should be disabled as well.
  2. Or user can switch to spreadCycle but G28 switches to stealthChop and does not return to spreadCycle. So user has to add extra G code after each G28. That's not nice.

This change adds few bytes to the FW size and does not alter behavior or performance of original printers which uses original profiles.

@bkerler
Copy link

bkerler commented May 28, 2025

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.