XL: Disable temp sensor chamber as it doesn't exist, causing wrong chamber temp report#4674
Open
bkerler wants to merge 1 commit intoprusa3d:masterfrom
Open
XL: Disable temp sensor chamber as it doesn't exist, causing wrong chamber temp report#4674bkerler wants to merge 1 commit intoprusa3d:masterfrom
bkerler wants to merge 1 commit intoprusa3d:masterfrom
Conversation
bkerler
changed the title
|
prusa XL has temp chamber senzor: |
Author
|
@Ro3Deee Thanks for pointing out, but the chamber temp sensor used in Marlin isn't used in Prusa XBuddy Firmware, as Prusa uses its own Chamber API for that. Also you are referring to the ambient temp sensor. |
bkerler
force-pushed
the
chamber_fix_xl
branch
from
6b5d4ce to
b808729
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves issue #3848.
Issue: If the device doesn't have a heated chamber, then chamber temps shouldn't be reported via gcode M155.
Solution: on XL, TEMP_SENSOR_CHAMBER was defined as 2000, which was invalid. Setting the value to 0 disables the TEMP_SENSOR_CHAMBER, thus M155 no longer will report a chamber temperature that doesn't exist.