gui: Add footer info for current z layer#4775
Draft
bkerler wants to merge 148 commits intoprusa3d:masterfrom
Draft
gui: Add footer info for current z layer#4775bkerler wants to merge 148 commits intoprusa3d:masterfrom
bkerler wants to merge 148 commits intoprusa3d:masterfrom
Conversation
If we receive a stray chunk (leftover from an aborted transfer), don't panic and kill the connection, just blackhole it silently and keep the connection. Creating new connections is expensive. BFW-6522.
(In websocket mode) update the download backup file before going to process a command; that way the command sees as fresh data of the file as possible and also, if it takes a long time / gets stuck, the other threads get an update. BFW-6428.
In addition to updating every 10s, make sure to also update every X bytes transfered, so we don't lose as much and have higher chance to show the preview sooner. BFW-6428.
It turns out copy-pasting iX config file has its flaws. BFW-6536
This is an improved ramming sequence from the Slicer team. BFW-6536
BFW-6538
BFW-6538
BFW-6543
This fixes CORE One missing M260 and M261 support. BFW-6546
I was wrong to do f2fb85b. BFW-6407
Testers were complaining that it's impossible to put out the print bed on aborted print. BFW-6551
The user needs to be clean out the purged filament easily. BFW-6551
and get rid of dependency on danol.cz
BFW-6552
BFW-6420 (cherry picked from commit a4ab096d47f006a9328d54fc7597af698cc603bd)
The inject queue is not equipped to handling non-constexpr strings at the moment. This commit ensures that we're only passing in literals.
Only the construction from the const char* has to be consteval, rest can be only constexpr
ConstexprString was previously okay when you passed him a buffer whose pointer was known at compile time, but contents were runtime - this change prevents that.
This reverts commit 51a37d6.
This fixes a regression introduced in 636c23f BFW-6680
subrepo: subdir: "lib/Prusa-Error-Codes" merged: "6fa23d43d5" upstream: origin: "git@github.com:prusa3d/Prusa-Error-Codes.git" branch: "master" commit: "6fa23d43d5" git-subrepo: version: "0.4.9" origin: "https://github.com/ingydotnet/git-subrepo" commit: "cce3d93"
git subrepo pull ./lib/Prusa-Error-Codes
(and save us one if) BFW-6679
Last minute product decisions are the best. BFW-6695
BFW-6600
The macOS build includes a `.tar.xzg` file, which 1bfe80a does not properly handle. This simply adds this extension to the list which should be extracted with tar instead of zip.
…utside the derived class
…and fix reorder compilation warning
bkerler
force-pushed
the
current_layer_footer
branch
from
3f2c7fe to
e1f8af0
Compare
bkerler
force-pushed
the
current_layer_footer
branch
from
e1f8af0 to
c34de01
Compare
CZDanol
requested changes
Aug 26, 2025
Contributor
There was a problem hiding this comment.
I'm sorry, but this is imo not admissible. The algorithm used for calculating the layer height is not reliable. It report wrong numbers if variable layer length is used, and also during toolchanges, zhops, probings and so on.
The only proper solution that comes to my mind would require asking slicer to start emitting gcodes that would report the layer number.
Author
|
@CZDanol yeah, understood. Moving this request to draft for now. Will keep you updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a footer that displays the current layer number, layer height is calculated using gcode metadata (includes layer_height and first_layer_height variables). Refers to issue #1485.
Example:
