gcode: Improve M106 (uint16_t vs. float)#4818
Open
bkerler wants to merge 1 commit intoprusa3d:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the reprap gcode and the prusa firmware, the M106 S Parameter is parsed as a uint16_t value between 0 and 255.
However, the gcodes that PrusaSlicer is sending are reprap firmware compatible and thus are represented as a real value.
Example, expected is:
M106 S107PrusaSlicer sends:
M106 S107.1The current firmware does parse this as an unsigned short value, which using inline function is parsed with strtol but instead it should be parsed as float value (strdold or strtod) and then used as a uint16_t value with range between 0 and 255.
Also, in order to improve speed, the S parameter is fixed to only be parsed once and not twice and instead of the NOMORE define we use std::clamp instead. The description of A was also missing and has been added according to what the parameter is used for.