mk4: add optional xBuddy Extension support (opt‑in)#5052
Open
jbjardine wants to merge 1 commit intoprusa3d:masterfrom
Open
mk4: add optional xBuddy Extension support (opt‑in)#5052jbjardine wants to merge 1 commit intoprusa3d:masterfrom
jbjardine wants to merge 1 commit intoprusa3d:masterfrom
Conversation
- add ENABLE_XBUDDY_EXTENSION_MK4 gate (default OFF) - add mk4-extension presets and mk4-xbuddy-extension preset - align MK4+xBuddy behavior with COREONE (chamber/side leds/door sensor calibration) - keep MK4 default unchanged and use MK4_XBUDDY error-code set
jbjardine
force-pushed
the
mk4-xbuddy-extension
branch
from
4844517 to
99181f9
Compare
Author
|
Quick note: this PR is opt‑in only (ENABLE_XBUDDY_EXTENSION_MK4=ON). Default MK4 behavior unchanged. Refs #4930. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an opt‑in MK4 configuration that enables xBuddy Extension support to match COREONE behavior, without changing the default MK4 firmware.
What’s changed
ENABLE_XBUDDY_EXTENSION_MK4(default OFF) and corresponding presets.Features enabled only when
ENABLE_XBUDDY_EXTENSION_MK4=ONxBuddy Extension support
HAS_XBUDDY_EXTENSION+XBUDDY_EXTENSION_VARIANT_STANDARDfor MK4→ extension firmware bundled, puppy bus tasks enabled, extension UI items.
Puppies bootloader on MK4
PRINTERS_WITH_PUPPIES_BOOTLOADER += MK4→ required for the extension/puppy flow.
Chamber + filtration APIs
HAS_CHAMBER_API+HAS_CHAMBER_FILTRATION_APIfor MK4→ chamber thermistor, chamber fans, filtration fan, filtration UI.
Side LEDs
HAS_SIDE_LEDSfor MK4→ RGB side strip via extension (no main‑board driver).
Side filament sensor + sensors menu
HAS_SIDE_FSENSOR+HAS_FILAMENT_SENSORS_MENUfor MK4→ side sensor support and full filament sensors menu.
Door sensor calibration
HAS_DOOR_SENSOR_CALIBRATIONfor MK4→ selftest/diagnostics step (sensor can still be disabled in UI).
Safety features
HAS_EMERGENCY_STOP+HAS_CEILING_CLEARANCEfor MK4→ match COREONE enclosure safety behavior.
Non‑goals / no regressions
ENABLE_XBUDDY_EXTENSION_MK4=OFF(same codepaths and sizes).Tests
mk4_release_boot(no extension): size identical to baseline.mk4-extension_release_boot: build OK.mk4-xbuddy-extension_release_boot: build OK.coreone_release_boot: build OK.Refs #4930
Disclaimer
This is an opt‑in, community/experimental configuration intended for users who retrofit MK4/MK3.9 with an xBuddy Extension and an enclosure. It does not change the default MK4 firmware behavior.