Spelling consistency: Gcode/G-Code/GCode -> G-code#5080
Open
smoe wants to merge 1 commit intoprusa3d:masterfrom
Open
Spelling consistency: Gcode/G-Code/GCode -> G-code#5080smoe wants to merge 1 commit intoprusa3d:masterfrom
smoe wants to merge 1 commit intoprusa3d:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is a tough call, but whatever spelling of "G-code" is used - it should be used consistently. Wikipedia, RepRap and LinuxCNC on the hyphen, a capital "G" and the lowercase "c". And also in header lines, I would treat "G-codes" as one term and not capitalize the "c", especially so when other words in that header are not capitalized..
This PR got triggered while exploring the menus of the printer, so it is the user visible changes that I initially wanted to be more close to perfect. While at it, the patch now also addresses comment lines. In retrospect, those invisible changes may even be more important for a grepping in the source code because of the often missing hyphen.
I have not changed the Doxygen group name "G-Codes", anticipating to disturb some downstream processing. Direct me if you prefer those adapted, too.