pause: Fix infinite loop in filament stuck logic with MMU#5082
Open
m42e wants to merge 1 commit intoprusa3d:masterfrom
Open
pause: Fix infinite loop in filament stuck logic with MMU#5082m42e wants to merge 1 commit intoprusa3d:masterfrom
m42e wants to merge 1 commit intoprusa3d:masterfrom
Conversation
m42e
changed the title
Author
|
|
When the filament is stuck on a printer with MMU (e.g. MK4S), the firmware would enter an infinite loop in the pause state machine because 'LoadType::filament_stuck' was not handled in 'mmu_unload_start_process'. This change adds the missing case to allow the MMU to unload and eject the stuck filament.
m42e
force-pushed
the
4791-mabi-fix-filament-stuck-mmu-hang
branch
from
ffc000c to
d80c508
Compare
m42e
changed the title
|
I can confirm that this works as intended on MK3.9S with MMU3. Off topicThank you thank you thank you thank you thank you!! |
|
Does anyone know when this type of fix is going to be provided to the public by Prusa? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the filament is stuck on a printer with MMU (e.g. MK4S), the firmware would enter an infinite loop in the pause state machine because 'LoadType::filament_stuck' was not handled in 'mmu_unload_start_process'.
This change adds the missing case to allow the MMU to unload and eject the stuck filament.
Fixes #4791
IMHO: I am not sure if you would want to handle this error case differently and maybe try to reload the filament a few times more to automatically resolve the filament stuck error in the case it happens mid-print. This will now lead to a pause but the user will be able to continue after removing and reinserting the filament into the MMU.