Fix _encode_files detection for __getattr__-based file wrappers#7502
Merged
Conversation
Contributor
Author
nateprewitt
requested changes
Jun 8, 2026
nateprewitt
left a comment
nateprewitt
left a comment
Member
There was a problem hiding this comment.
Thanks for this, @LoicPernod! I have a couple changes we should make but otherwise this seems reasonable. Also, please make sure you run pre-commit on the change before you push up the next round of changes.
LoicPernod
force-pushed
the
loicp/fix-tempfile-requests
branch
from
e7de262 to
be53ff1
Compare
nateprewitt
approved these changes
Jun 8, 2026
nateprewitt
left a comment
nateprewitt
left a comment
Member
There was a problem hiding this comment.
Thanks again, @LoicPernod!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.