port(ed?) to plasma 6 #214
Open
+3,488
−3,231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the chances of getting this merged are quite low as @psifidotos has been absent for a while. Nevertheless, its very cool to see your efforts :) Question: is this confirmed to work on KDE release builds? I'm asking because it compiles successfully when using Arch's This is the error I'm getting during compilation: |
|
Hmm this is interesting, I've never tested it on KDE master branch (should be in extra-staging rn?). |
|
Yes, it's in staging already. Thanks for taking a look once you are able to. |
screenGeometry now belongs to PlasmoidItem
Several macros expected major=5 and minor>x (e.g. kdecorations 5.13 or 5.21), checking only minor, which broke with Plasma 6.0.0 stable release (minor=0). This fixes it in some dirty way, assuming major is either 5 or 6.
|
Thanks @luisbocanegra and @andrevmatos for moodyhunter/applet-window-buttons6#2 moodyhunter/applet-window-buttons6#1, the compilation failure is fixed. |
|
Hi, thanks for your port. I'm using it in Fedora 40. I have an issue though, and your issue tracker is off. Screencast_20240301_154243.webmClosing child window with buttons from applet closes parent window too. It should only close child window. Operating System: Fedora Linux 40 |
|
Hi, @hazel-bunny GitHub defaults not to enable Issues for forked repos, anyway, it's been enabled now. I'll try to investigate your issue asap. **disclaimer: I'm not familiar with applet-window-buttons right now, as my initial intention was the Qt6 porting |
it's just unused
fix toggle all desktops button
D3SOX
reviewed
Mar 10, 2024
Co-authored-by: Nico <[email protected]>
…is not going to be ported to Plasma 6
Added new Setting KWin BorderlessMaximumWindows to the Behavior Page. This setting uses a C++ QML Extension that manipulates ~/.config/kwinrc with KConfig and uses DBus to reload the KWin Config if necessary. KWins BorderlessMaximumWindows is set by a lot of people that use this applet.
Plasma 6.3 comes with a new major version of the KDecoration libary with some breaking changes
Fixed build error.
Adapt to KDecoration3/Plasma 6.3
Update build dependencies for Ubuntu
Removed Latte-Dock specific code from the applet, because Latte Dock … > I added a setting to configure the KWin option BorderlessMaximizedWindwos, which makes sense, because its only real use case is given, when using this plasmoid. > I added a new Behavior tab to the settings page, which uses Kirigami like the KDE stock plasmoids. > The existing General page can not be converted to Kirigami Formlayout, because the Drag and Drop of the functionality of the rearrange buttons feature does not work then. > For now I´d suggest to keep it as it is. (unlike Kirigami it is not responsive, when resizing the window) > The licenses were converted with kde licensedigger to the recommended reuse compliant spdx format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KDE 6 will be released tomorrow, so it's probably the time to open this PR
similar like psifidotos/applet-window-title#153, the ported version has been running on my machine for more than 2 months without noticeable issue.
This is a breaking change to support Qt6, which means the drop of Qt5/plasma5 support.
Q*Pointer<>tostd::*_ptr<>root.plasma515property as 6 alwaysA
ColorOverlayis removed from AuroraeButton (short lives qtgraphicaleffects!), andQPalette::Baseis now used asm_activeFrameColor, no idea of what implication will be, but this does look ok.