Skip to content

ensure saveable_sklearn.py saves string arrays with dtype=str #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
niklas-gerl wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ensure saveable_sklearn.py saves string arrays with dtype=str #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion psipy/core/io/saveable_sklearn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
SaveableSklearnMixin

"""
import numpy as np

from typing import Any, Dict

Expand Down Expand Up @@ -53,7 +54,12 @@ def get_config(self) -> Dict[str, Any]:

def _save(self, zipfile: MemoryZipFile) -> MemoryZipFile:
zipfile.add("config.json", self.get_config())
zipfile.add_mixed_dict("state", self.__getstate__())
state_dict = self.__getstate__()
for key, arr in state_dict.items():
if isinstance(arr, np.ndarray) and arr.dtype == object:
if all(isinstance(x, str) for x in arr.flat):
state_dict[key] = arr.astype(str)
zipfile.add_mixed_dict("state", state_dict)
return zipfile

@classmethod
Expand Down