Add variable to skip updating the server#70
Conversation
WilliamVenner
left a comment
WilliamVenner
left a comment
There was a problem hiding this comment.
confirm for me that the server boots with SKIP_UPDATE=0 and SKIP_UPDATE=1 (sorry, in the absence of a test suite, you'll have to be it 😆) with this image and I shall merge 🙂
Will do so later, as I am currently not on my PC 👍 |
Here's a video showing the entire process from download server files to the server booting with both Skip Update on or off 8mb.video-yEO-zyOkIBkc.mp4 |
|
I wonder if we should invert the logic here and use |
|
We “should”, yeah, but that’s a breaking change unfortunately. |
How is it a breaking change when nothing that uses it has been merged yet? |
|
sorry yes, ignore me. For some reason I thought this was a wings PR. 😅 |
| if ! [[ -e version ]] || [ "$curversion" != "$(cat "version")" ]; then | ||
| if [[ -f version ]]; then | ||
| echo -e "New update available, downloading version $curversion..." | ||
| if [[ "${SKIP_UPDATE}" == "1" ]]; then |
There was a problem hiding this comment.
Please invert the logic so it follows the current convention of AUTO_UPDATE.
If unset or empty, assumed true
There was a problem hiding this comment.
Since this is about skipping the update, not auto updating, do you want to assume it as off instead, if unset or empty, thus updating it, unless it's 1, thus skipping?
My next commit should be able to show what I am talking about.
Since this is about skipping update, not autoupdate, I believe using the same logic as AUTO_UPDATE, but inverting it for SKIP_UPDATE to be the way to go. Correct me if I am wrong
3 participants
As title states.
This skips the download part only.
Has been requested, and can be of importance.
It's a boolean, so either the update is skipped or not, default is no.
Adding this variable is needed, but I will PR on the egg side of things too:
Edit: It's for Hytale