Repository navigation
[RV64_DYNAREC] Avoid redundant vsetvli when loading vector masks - #4583
Merged
Merged
Conversation
ptitSeb
approved these changes
Oct 21, 2026
ksco
approved these changes
Oct 22, 2026
| abort(); | ||
| } else { | ||
| uint8_t sv_sew, sv_vlmul, sv_vl; | ||
| if (sew < VECTOR_SEW8 || sew > VECTOR_SEW64) |
Collaborator
There was a problem hiding this comment.
sew cannot < VECTOR_SEW8, this is never true.
1. Trim mask immediates to the active vector element count to avoid setting unused bits. 2. Reuse the vector configuration when its element width can hold all active mask bits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trim mask immediates to the active vector element count to avoid setting unused bits.
Reuse the vector configuration when its element width can hold all active mask bits.