Cosmwasm 2.0+ #179
Merged
Cosmwasm 2.0+ #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deniszagumennov
force-pushed
the
main
branch
from
eb23c29 to
ea8fca4
Compare
deniszagumennov
force-pushed
the
main
branch
from
9288f6d to
4294a80
Compare
deniszagumennov
force-pushed
the
main
branch
2 times, most recently
from
6cd821c to
45c8e5e
Compare
deniszagumennov
force-pushed
the
main
branch
10 times, most recently
from
0822058 to
8e32724
Compare
deniszagumennov
force-pushed
the
main
branch
from
8e32724 to
3b14a94
Compare
deniszagumennov
force-pushed
the
main
branch
from
3b14a94 to
f943b41
Compare
jhernandezb
reviewed
Feb 24, 2025
jhernandezb
reviewed
Feb 24, 2025
jhernandezb
reviewed
Feb 24, 2025
packages/cw721/src/msg.rs
Outdated
| { | ||
| // if Some(bool), bool represents the `is_owner` check result. | ||
| // if None, `info` was none and the check is skipped. | ||
| Ok(is_minter) => is_minter.unwrap_or(true), |
Contributor
There was a problem hiding this comment.
I feel like this variable should be named something like is_minter_owner ?
packages/cw721/src/msg.rs
Outdated
| let creator_initialized = CREATOR.item.may_load(deps.storage)?; | ||
| let is_creator_or_uninitialized = | ||
| match sender.map(|addr| is_owner(deps.storage, addr)).transpose() { | ||
| // if Some(bool), bool represents the `is_owner` check result. |
Contributor
There was a problem hiding this comment.
Generally I'm wary of comments explaining code, is there a way to name the variables so its self documenting?
Contributor
Author
There was a problem hiding this comment.
I tried, please check it out
shanev
reviewed
Feb 25, 2025
Member
shanev
left a comment
shanev
left a comment
There was a problem hiding this comment.
LGTM as long as the comments by @jhernandezb and @humanalgorithm are addressed.
deniszagumennov
force-pushed
the
main
branch
from
24028fe to
df9fb7a
Compare
deniszagumennov
force-pushed
the
main
branch
3 times, most recently
from
fbe6463 to
ea22eb1
Compare
deniszagumennov
force-pushed
the
main
branch
from
ea22eb1 to
665ed12
Compare
jhernandezb
approved these changes
Feb 26, 2025
Member
|
Thank you @deniszagumennov !! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #172 Pull Request, another attempt to update CosmWasm in the contracts