Fix(lexer): prevent false positive matching of 'of' keyword in string… #3464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… literals
The eachOf regex was incorrectly matching the word 'of' inside string values
when parsing 'each...in' loops, causing syntax errors for valid code.
Example that previously failed:
each link in ['Terms of service', 'Privacy policy', 'License']
a= link
Changed the regex from /^(?:each|for) (.*?) of *([^\n]+)/ to require:
- Explicit whitespace around the 'of' keyword
- Valid variable patterns (identifier or [key, value] destructuring)
This ensures 'of' is recognized as a keyword only when used as such,
not when it appears within string literals in the iterable expression.
|
There is no change log for this pull request yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… literals
The eachOf regex was incorrectly matching the word 'of' inside string values when parsing 'each...in' loops, causing syntax errors for valid code.
Example that previously failed:
each link in ['Terms of service', 'Privacy policy', 'License']
a= link
Changed the regex from /^(?:each|for) (.*?) of *([^\n]+)/ to require:
This ensures 'of' is recognized as a keyword only when used as such, not when it appears within string literals in the iterable expression.