-
Notifications
You must be signed in to change notification settings - Fork 13
Bunch of fixes and changes #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lukamac
wants to merge
21
commits into
pulp-platform:devel
Choose a base branch
from
lukamac:bag-of-fix
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those flags are not actually common. The -Wl,--gc-section does not exist on Apple's llvm build but should be replaced by -Wl,-dead_strip by this (stackoverflow post)[https://stackoverflow.com/a/24799865]. -ffast-math flag caused some numerical errors probably due to aggressive optimizations so I disabled it for the Generic target since that one is supposed to be more for debugging.
Slightly more legible outer loop
The ONNX spec defines kernel_shape as optional because it can be inferred from the weight's shape. This commit changes the parser to allow for that.
6a9546a
to
1889383
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been working on adding support for an updated Neureka gvsoc model. Furthermore, I was writing a script that fakes quantization and wanted to use the Generic target for testing it.
This is a collection of small fixes and changes I needed for this. I am creating a pull request now because I'm abandoning the effort in the Generic platform and going straight for the siracusa platform.
Best reviewed commit by commit.
Added
Changed
Fixed
-Wl,--gc-sections
flag, moved it into each target and for host it's checking now for host system--ffast-math
caused numerical errors on generic so moved into each target and removed from that one since I'm imagining it as the debug targetPR Merge Checklist
devel
commit and pointing todevel
.CHANGELOG.md
file has been updated.