-
Notifications
You must be signed in to change notification settings - Fork 89
treewide: Replace pip in favor of uv
#286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fischeti
wants to merge
33
commits into
pulp-platform:main
Choose a base branch
from
fischeti:uv
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uvis a newer python package manager that is becoming more popular and it facilitates a couple of issues that we currently have. Essentially, it is a drop in replacement forpipand operates on thepyproject.tomldescription. But it has a couple of features and advantages that make it worth adapting:uv.lockto lock the resolved python package version used in the project (and subprojects). This will also be familiar to people using bender (in fact bothuvand bender are inspired by Cargo).python-version)snitch_clusterrepository but for instance in picobello (see wip here), I can specify bothfloogenandsnitch_clusteras dependencies and it will resolve the dependencies together, which is very convenient.pyproject.tomlitself (looking at torch cpu-only version 👀).pip🚀 and the way it is implemented now still supportspipbased installationsTODOs
uvshould be taken from in the IIS environment. It is a small binary that could be installed on the fly, but we could also install it system wideAdapt(inlined the action now with the uv environment)list-dependent-make-targetsto specify python