Skip to content

[PR #1378/553a5355 backport][3.8] Teach modelresource.render to handle None values. #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggainey merged 1 commit into from
Jan 8, 2026
Merged

[PR #1378/553a5355 backport][3.8] Teach modelresource.render to handle None values. #1379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGES/+imp_exp_4_prep.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Teach modelresource.render it might get a `value` of None.

This prepares us to handle a django-import-export/4 codepath.
4 changes: 4 additions & 0 deletions pulp_deb/app/modelresource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,8 @@ class ReleaseComponentForeignKeyWidget(ForeignKeyWidget):

def render(self, value, obj=None, **kwargs):
"""Render formatted string to use as unique-identifier."""
if not value:
return ""
rc_dist = value.distribution
rc_comp = value.component
return f"{rc_dist}|{rc_comp}"
Expand All @@ -177,6 +179,8 @@ class PackageForeignKeyWidget(ForeignKeyWidget):

def render(self, value, obj=None, **kwargs):
"""Render formatted string to use as unique-identifier."""
if not value:
return ""
pkg_relative_path = value.relative_path
pkg_sha256 = value.sha256
return f"{pkg_relative_path}|{pkg_sha256}"
Expand Down