[autocomplete-plus] Ensure editor is re-focused…#1552
Open
savetheclocktower wants to merge 3 commits into
Open
[autocomplete-plus] Ensure editor is re-focused…#1552savetheclocktower wants to merge 3 commits into
savetheclocktower wants to merge 3 commits into
Conversation
…after the user selects a suggestion via the mouse.
Member
|
Spec failure in autocomplete-plus: |
Contributor
Author
|
The newly failing spec probably describes a scenario that could not be replicated in the real world, but it was worth fixing anyway. The system works! |
Contributor
Author
|
Just pushed another commit to add the spec I threatened to add. The new spec fails on |
Contributor
Author
|
Bump; would be good to get an approval on this one. Might land it anyway if nobody objects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…after the user selects a suggestion via the mouse.
@DeeDeeG observed this one in Discord and I was able to reproduce it, so I thought I'd get to the bottom of it while my attention span allowed me to!
Easy fix,
but I have not written tests, nor have I investigated how easily this could be tested in automated fashion. We'd have to simulate a click with enough fidelity that the focus actually moved onto the suggestion element. I might return to this to write the spec later, or someone might manually verify it and then approve it before I get around to it!(EDIT: Spec has been written!)Testing
On
master, nothing will happen, because focus isn't actually in the editor (even though you can see the cursor blinking).On this PR branch, focus should return to the editor immediately so you can continue typing.