Expand wit-bindgen fixtures to 14 and add multi-memory unit tests#23
Merged
Expand wit-bindgen fixtures to 14 and add multi-memory unit tests#23
Conversation
…nit tests Add 5 new wit-bindgen fixtures (results, lists-alias, strings-alias, strings-simple, fixed-length-lists) with 3 test levels each. Resources and fixed-length-lists gracefully degrade for known limitations. Add targeted unit tests for multi-memory WASI import lowering: - Merger: component-aware dedup, import metadata, cabi_realloc$N exports - Wrapper: multi-memory stubs, $N suffix stripping in resolve_import Update CI workflow with smarter fixture copy pattern for varying composed artifact filenames. Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
results,lists-alias,strings-alias,strings-simple,fixed-length-listsContext
Expanding fixture coverage based on analysis of wit-bindgen upstream test suite (32 runtime fixtures).
The 5 new fixtures address gaps a knowledgeable reviewer would notice: Result<T,E> ABI lowering,
type alias regression coverage, and Christof Petig's fixed-length-lists spec feature.
14 fixtures total across 3 test levels (core module, component, runtime) = 42 integration tests.
195 tests total, all passing.
Known limitations (graceful degradation)
[resource-new]/[resource-rep]supportTest plan
cargo test— 195 tests passcargo clippy --all-targets— no warningscargo fmt -- --check— clean🤖 Generated with Claude Code