fix: propagate resource type aliases in resource import map#31
Merged
Conversation
Component function parameters may reference a resource via an ExportAlias (e.g., Borrow(24) where type 24 is ExportAlias(25)), while canonical ResourceRep/ResourceNew entries use the target type. The resource map now includes both alias source and target IDs so resolve_resource_positions can find imports for either type ID. This partially fixes resource detection in 3-component chains where the intermediate component's type system has aliased resource types. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
avrabe
added a commit
that referenced
this pull request
Mar 18, 2026
fix: propagate resource type aliases in resource import map (#31) fix: resolve instance alias arguments in propagate_outer_wiring When a composed component uses alias export to create an instance alias, propagate_outer_wiring now correctly resolves the alias to find the source sub-component. Previously only direct Instance entries were mapped; alias-created instances silently failed. Changes instance_infos from Vec to HashMap keyed by absolute instance index, and handles InstanceExportAlias by chasing the alias chain. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
avrabe
added a commit
that referenced
this pull request
Mar 18, 2026
* fix: resolve instance alias arguments in propagate_outer_wiring When a composed component uses `alias export $inst "..." (instance)`, propagate_outer_wiring now correctly resolves the alias to find the source sub-component. Previously only direct Instance entries were mapped; alias-created instances silently failed, causing import resolution to fall back to "first non-self match" by name. Changes instance_infos from Vec to HashMap keyed by absolute instance index, and handles InstanceExportAlias by chasing the alias chain. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: resolve imported resource types in resource position lookup (#32) fix: propagate resource type aliases in resource import map (#31) fix: resolve instance alias arguments in propagate_outer_wiring When a composed component uses alias export to create an instance alias, propagate_outer_wiring now correctly resolves the alias to find the source sub-component. Previously only direct Instance entries were mapped; alias-created instances silently failed. Changes instance_infos from Vec to HashMap keyed by absolute instance index, and handles InstanceExportAlias by chasing the alias chain. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build_resource_type_to_importthat propagates resource map entries throughExportAliastype chainsBorrow(24)but the canonicalResourceRepuses type 25 (where 24 is ExportAlias(25)), the map now includes both type IDsTest plan
🤖 Generated with Claude Code