changed proposed items #16380

vazudew · 2025-10-24T11:42:25Z

Proposed changes

Installing ESO Operator via Helm on k8s, needed exact Chart Version and to install all CRDs used. So fixed.
Fix: #16379

Unreleased product version (optional)

Related issues (optional)

claude · 2025-10-24T11:43:50Z

Review of PR #16380

Thanks for contributing to fix the External Secrets Operator installation! I've reviewed the changes and have some observations:

Technical accuracy ✓

The Helm command syntax is correct and the parameters are valid:

--set installCRDs=true ensures the Custom Resource Definitions are installed
--version 0.10.4 pins to a specific chart version

Concerns

1. Version pinning to 0.10.4 (line 48)

Version 0.10.4 appears to be quite old. External Secrets Operator has had many releases since then. Pinning to an older version in a tutorial could:

Expose users to known security vulnerabilities
Prevent users from accessing newer features and bug fixes
Create maintenance burden when the tutorial eventually needs updating

Suggestion:
Consider either:

Using the latest stable version (check the External Secrets Operator releases)
Not pinning to a specific version (let Helm use the latest from the repo)
If 0.10.4 is required for compatibility with a specific Pulumi ESC version, add a comment explaining why

helm upgrade --install external-secrets external-secrets/external-secrets \
    --namespace external-secrets \
    --set installCRDs=true \
    --create-namespace \
    --wait

2. Missing context for readers

The tutorial doesn't explain why --set installCRDs=true is necessary. Adding a brief comment or note would help users understand the configuration.

Testing recommendation

Since this changes installation instructions in a tutorial, please verify:

The specified version (0.10.4) is still available in the Helm repository
The installation completes successfully with these parameters
The rest of the tutorial steps work correctly with this version

Mention me (@claude) if you'd like additional reviews or help addressing these concerns!

stooj

Where does the version number (0.10.0) come from?

Can we include a paragraph about finding the correct version number to use, then update the code sample with a placeholder version number instead?

--version <VERSION_NUMBER>

That means when the version number changes in 6 months we're not still instructing users to install an old version.

pulumi-bot · 2025-10-24T11:49:38Z

Your site preview for commit fd61f96 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-16380-fd61f967.s3-website.us-west-2.amazonaws.com.

vazudew · 2025-10-27T13:40:12Z

I executed the commands, k8s objects with a colleague. Updated the sample code for namespaces

pulumi-bot · 2025-10-27T13:45:48Z

Your site preview for commit 43c2f1b is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-16380-43c2f1b9.s3-website.us-west-2.amazonaws.com.

stooj

A couple of small comments before this can be merged.

stooj · 2025-10-27T14:08:52Z

content/tutorials/esc-external-secret-operator/index.md

 #### Create ClusterSecretStore

-Now you can create a [ClusterSecretStore](https://external-secrets.io/main/api/clustersecretstore/) resource that will tell External Secrets Operator to use Pulumi ESC as a secret provider.
+You can create a [ClusterSecretStore](https://external-secrets.io/main/api/clustersecretstore/) resource that will tell External Secrets Operator to use Pulumi ESC as a secret provider.


Rearrange this so the reader reads their instructions first in case they aren't paying close attention.

Something like:

You can create a SecretStore resource that will tell the External Secrets Operator to use Pulumi ESC as a secret provider for this namespace. If you want to increase the scope of the whole cluster you can use a ClusterSecretStore instead.

changed the section, accordingly :)

stooj · 2025-10-27T14:10:18Z

content/tutorials/esc-external-secret-operator/index.md

-  - secretKey: esc-secret
-    remoteRef:
-      key: hello
+    - secretKey: esc-secret


Can you please lint this yaml? There has been extra indentation added, so check it's still valid.

woow, good catch. The error was due to copy paste issue. Updated

latest master branch is merged to local branch. It will be easy for merging onto origin master

pulumi-bot · 2025-10-27T16:47:11Z

Your site preview for commit 20e76bf is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-16380-20e76bf5.s3-website.us-west-2.amazonaws.com.

pulumi-bot · 2025-10-27T16:48:23Z

Your site preview for commit edcb694 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-16380-edcb6948.s3-website.us-west-2.amazonaws.com.

stooj

Just a couple of grammar fixes

stooj · 2025-10-28T09:47:06Z

content/tutorials/esc-external-secret-operator/index.md

+You can create a [SecretStore](https://external-secrets.io/main/api/secretstore/) resource to notify External Secrets Operator to use Pulumi ESC as a secret provider for a specific namespace.

-If you want to limit the access by namespace, you can create a [SecretStore](https://external-secrets.io/main/api/secretstore/) resource instead, which is scoped to a single namespace.
+However if you want to expand the scope to entire cluster, you can use a [ClusterSecretStore](https://external-secrets.io/main/api/clustersecretstore/) resource, instead.


Grammar fixes:

However, if you want to expand the scope to the entire cluster you can use a ClusterSecretStore resource instead.

stooj · 2025-10-28T09:48:04Z

content/tutorials/esc-external-secret-operator/index.md

 #### Create ClusterSecretStore

-Now you can create a [ClusterSecretStore](https://external-secrets.io/main/api/clustersecretstore/) resource that will tell External Secrets Operator to use Pulumi ESC as a secret provider.
+You can create a [SecretStore](https://external-secrets.io/main/api/secretstore/) resource to notify External Secrets Operator to use Pulumi ESC as a secret provider for a specific namespace.


Grammar fixes:

You can create a SecretStore resource to notify the External Secrets Operator to use Pulumi ESC as a secret provider for a specific namespace.

stooj · 2025-10-28T10:11:25Z

content/tutorials/esc-external-secret-operator/index.md

-Please replace `${PULUMI_ORG}`, `${ESC_PROJECT}`, `${ESC_ENV}` with your Pulumi organization, project, and environment names.
+Please replace `${PULUMI_ORG_NAME}`, `${ESC_PROJECT_NAME}`, `${ESC_ENV_NAME}` with your Pulumi organization, project, and environment names.

 For demo purposes, we assume that we already have an [ESC environment](/docs/esc/get-started/create-environment/) `my-org/my-project/my-env` with a secret `my-secret` that we want to manage using External Secrets Operator.


Grammar fix:

using the External Secrets Operator.

pulumi-bot · 2025-10-28T11:11:46Z

Your site preview for commit 9194a21 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-16380-9194a217.s3-website.us-west-2.amazonaws.com.

stooj

Almost there!

stooj · 2025-10-28T11:10:14Z

content/tutorials/esc-external-secret-operator/index.md

+You can create a [SecretStore](https://external-secrets.io/main/api/secretstore/) resource to notify the External Secrets Operator to use Pulumi ESC as a secret provider for a specific namespace.

-However if you want to expand the scope to entire cluster, you can use a [ClusterSecretStore](https://external-secrets.io/main/api/clustersecretstore/) resource, instead.
+However, if you want to expand the scope to entire cluster, you can use a [ClusterSecretStore](https://external-secrets.io/main/api/clustersecretstore/) resource instead.


One last comma to remove 😁

scope to entire cluster, you can use a

scope to the entire cluster you can use a

And a the to add.

me thinks, "scope to entire cluster, " is correct, because you need a short pause there ? But i can remove it, once you confirm the removal.

The to be added for "ClusterSecretStore"? we have been using article "a" for ClusterSecretStore. ? we have to replace all "a" s to "the" ? please confirm

If you've been using a then use an entire cluster, sounds good.

And you've convinced me about the comma 😁 Keep the comma.

pulumi-bot · 2025-10-28T11:41:26Z

Your site preview for commit 730a4a7 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-16380-730a4a70.s3-website.us-west-2.amazonaws.com.

stooj

LGTM

changed proposed items

fd61f96

vazudew requested a review from stooj October 24, 2025 11:42

vazudew temporarily deployed to testing October 24, 2025 11:42 — with GitHub Actions Inactive

stooj reviewed Oct 24, 2025

View reviewed changes

updated comments

43c2f1b

vazudew temporarily deployed to testing October 27, 2025 13:38 — with GitHub Actions Inactive

vazudew requested a review from stooj October 27, 2025 13:49

stooj reviewed Oct 27, 2025

View reviewed changes

vazudew added 2 commits October 27, 2025 16:35

changes as per review comments

6fc6d6b

fixed review comments

20e76bf

vazudew temporarily deployed to testing October 27, 2025 16:39 — with GitHub Actions Inactive

Merge branch 'master' into fix-16379

edcb694

latest master branch is merged to local branch. It will be easy for merging onto origin master

vazudew temporarily deployed to testing October 27, 2025 16:41 — with GitHub Actions Inactive

stooj reviewed Oct 28, 2025

View reviewed changes

apply grammar fixes

9194a21

vazudew temporarily deployed to testing October 28, 2025 11:05 — with GitHub Actions Inactive

stooj reviewed Oct 28, 2025

View reviewed changes

added an article

730a4a7

vazudew temporarily deployed to testing October 28, 2025 11:34 — with GitHub Actions Inactive

stooj approved these changes Oct 28, 2025

View reviewed changes

Uh oh!

changed proposed items #16380

Are you sure you want to change the base?

changed proposed items #16380

Uh oh!

Conversation

vazudew commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Unreleased product version (optional)

Related issues (optional)

Uh oh!

claude bot commented Oct 24, 2025

Review of PR #16380

Technical accuracy ✓

Concerns

Testing recommendation

Uh oh!

stooj left a comment

Choose a reason for hiding this comment

Uh oh!

pulumi-bot commented Oct 24, 2025

Uh oh!

vazudew commented Oct 27, 2025

Uh oh!

pulumi-bot commented Oct 27, 2025

Uh oh!

stooj left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pulumi-bot commented Oct 27, 2025

Uh oh!

pulumi-bot commented Oct 27, 2025

Uh oh!

stooj left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stooj Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pulumi-bot commented Oct 28, 2025

Uh oh!

stooj left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stooj Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pulumi-bot commented Oct 28, 2025

Uh oh!

stooj left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

vazudew commented Oct 24, 2025 •

edited

Loading

stooj Oct 28, 2025 •

edited

Loading

stooj Oct 28, 2025 •

edited

Loading