Skip to content

Conversation

@cnunciato
Copy link
Contributor

The API for the RestAPI resource seems to have changed. This fixes it up.

Fixes #16824.

@claude
Copy link
Contributor

claude bot commented Dec 20, 2025

Documentation Review

Summary

This PR correctly updates the apigateway.RestAPI example to match the current API. The changes look good overall, with proper syntax and structure.

Issues Found

Minor: Missing trailing comma (content/docs/iac/clouds/aws/guides/lambda.md:360)

The code example is missing a trailing comma after the closing brace on line 360. While not strictly required, adding it follows JavaScript/TypeScript best practices for consistency.

            }),
        },

✅ Style & Accuracy Check

  • ✅ Code syntax is correct
  • ✅ Import statements are properly ordered
  • ✅ Type annotations are applied correctly
  • ✅ The example demonstrates the API change clearly
  • ✅ Indentation is consistent
  • ✅ No spelling or grammar issues

Notes

The change from an inline arrow function to a CallbackFunction instance properly reflects the API update. The addition of the method: "GET" property and the import * as aws statement are necessary and correct.


Mention me (@claude) if you'd like additional reviews or fixes.

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@cnunciato cnunciato enabled auto-merge (squash) December 20, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeScript example for @pulumi/aws-apigateway eventHandler fails with type error

3 participants