Skip to content

Conversation

@tehsis
Copy link
Contributor

@tehsis tehsis commented Dec 20, 2025

Proposed changes

Added an image to exemplify policies configuration to the gitlab oidc doc and fixed minor formatting issues

@claude
Copy link
Contributor

claude bot commented Dec 20, 2025

Documentation Review

Thank you for improving the GitLab OIDC documentation! I found a few issues that need to be addressed:

Critical Issues

Missing image file (line 52)
The PR references an image that doesn't exist in the repository:

![Gitlab policy example](../gitlab-policies.png)

The image file gitlab-policies.png needs to be added to content/docs/administration/access-identity/oidc-client/ (or the appropriate parent directory based on the relative path). The existing register-gitlab.png image is located at content/docs/administration/access-identity/oidc-client/register-gitlab.png, so gitlab-policies.png should follow the same placement pattern.

Style Issues

Alt text capitalization (line 52)
The alt text should use consistent capitalization with the rest of the documentation. "Gitlab" should be "GitLab" (matching the official brand capitalization used throughout the document).

   ![GitLab policy example](../gitlab-policies.png)

Duplicate markdownlint comment (line 50)
There's a duplicate <!-- markdownlint-enable no-bare-urls --> comment. The diff shows two consecutive lines with the same comment, but only one is needed.

* **Sub**: project_path:***namespace***/***project***:ref_type:branch:ref:***branch-name***
<!-- markdownlint-enable no-bare-urls -->

Positive Changes

✓ Fixed the bullet list formatting by adding * before the Sub item
✓ Good placement of the image to illustrate the policies configuration


Next Steps:

  1. Add the gitlab-policies.png image file to the repository
  2. Fix the alt text capitalization
  3. Remove the duplicate markdownlint comment

Please mention me (@claude) if you'd like me to review the updated changes or need any clarification!

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants