Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ast: error recovery #221

Merged
merged 2 commits into from
Jan 29, 2024
Merged

ast: error recovery #221

merged 2 commits into from
Jan 29, 2024

Conversation

pgavlin
Copy link
Member

@pgavlin pgavlin commented Jan 29, 2024

Allow the parser to recover from errors and return its best possible AST. This is the first step towards allowing evaluation of environments that contain parse errors, which is vital for live analysis.

Allow the parser to recover from errors and return its best possible
AST. This is the first step towards allowing evaluation of environments
that contain parse errors, which is vital for live analysis.
@pgavlin pgavlin added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Jan 29, 2024
@pgavlin
Copy link
Member Author

pgavlin commented Jan 29, 2024

follow-up changes will update the evaluator to handle the new AST patterns, specifically:

  • interpolations that contain errors
  • fn::open calls that contain errors
  • fn::join calls that contain errors
  • fn::secret calls that contain errors

@pgavlin pgavlin enabled auto-merge (squash) January 29, 2024 21:51
@pgavlin pgavlin disabled auto-merge January 29, 2024 21:51
@pgavlin pgavlin enabled auto-merge (squash) January 29, 2024 21:51
@pgavlin pgavlin merged commit f893904 into main Jan 29, 2024
4 checks passed
@pgavlin pgavlin deleted the pgavlin/ast-error-recovery branch January 29, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants