Prepare v3 version files #3847
Merged
Prepare v3 version files #3847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Copy config from v2 as a starting point. - Init all other files as empty.
The IdentityProperties type has changed between versions and is used by the resources:
- CredentialSet
- ExportPipeline
- ImportPipeline
- Registry
- Task
- TaskRun
Therefore we have to manually pick these in the spec.
Exclude ReportConfig types which only have a single version (2018-05-31) but conflicts with the View resource. Remove old exclusion Go code for Budget and Report which doesn't actually have seemed to remove these resources in our v2 SDK.
- Exclude very old DatabaseAccount variations which are no longer used. - Move MongoCluster to its own module to match the SDK and fix additional conflicts as it's versioned completely separately. It still seems to show up as an addition for DocumentDB too, but isn't actually generated as a resource there.
Does the PR have any schema changes?Looking good! No breaking changes found. |
Only rename Urn properties directly on resource
Make it version-independent.
danielrbradley
force-pushed
the
prepare-v3-version-files
branch
from
96b13e1 to
aa1b3c1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3847 +/- ##
==========================================
- Coverage 56.99% 56.98% -0.02%
==========================================
Files 79 79
Lines 12284 12290 +6
==========================================
+ Hits 7001 7003 +2
- Misses 4758 4761 +3
- Partials 525 526 +1 ☔ View full report in Codecov by Sentry. |
thomas11
approved these changes
Jan 11, 2025
|
This is the first bulk of work towards #3448 |
|
This PR has been shipped in release v2.83.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from the work on the
v3branch: #3846This has no impact until the major version is changed in the makefile.