Bump NodeJS in base image to 18 #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dixler
force-pushed
the
dixler/148
branch
2 times, most recently
from
576b14c to
50c36c9
Compare
dixler
changed the title
dixler
requested review from
justinvp and
a team
and removed request for
a team
Frassle
approved these changes
Sep 7, 2023
dixler
commented
Sep 7, 2023
komalali
reviewed
Sep 8, 2023
| @@ -39,7 +39,7 @@ RUN apt-get update -y && \ | |||
| rm -rf aws && \ | |||
| rm awscliv2.zip && \ | |||
| # Add additional apt repos all at once | |||
| echo "deb https://deb.nodesource.com/node_16.x $(lsb_release -cs) main" | tee /etc/apt/sources.list.d/node.list && \ | |||
| echo "deb https://deb.nodesource.com/node_18.x $(lsb_release -cs) main" | tee /etc/apt/sources.list.d/node.list && \ | |||
There was a problem hiding this comment.
how do we make sure we don't get caught behind again? looks like Node 20 is becoming LTS starting October 24th
justinvp
reviewed
Sep 8, 2023
Before it was using `lts-bullseye-slim`, which is currently the same as `18-bullseye-slim`. This commit changes it it to `18-bullseye-slim` so that it remains on 18 once the LTS version changes. That way, we can upgrade all images to the next LTS version at the same time, and not have one images that is using a different version that the others.
Also tweak the cadence as we aim to release weekly now.
|
Commits look good. |
github-merge-queue bot
pushed a commit
to pulumi/pulumi
that referenced
this pull request
Sep 10, 2023
We're planning to release a new minor version of the CLI on Monday, both for some new features (e.g. CLI support for org search and AI) and also so that the docker containers for v3.82.0 are released on Monday [with Node 18](pulumi/pulumi-docker-containers#150) since Node 16 will be EOL. Going ahead and prepping the version bump now with this PR. I'll open and merge the associated freeze PR on Monday once the remaining org search PRs have been merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades Node.js in the
pulumi/pulumiimage andpulumi/nodejsUBI image to the Active LTS version 18, and documents our version policy to keep language runtimes up-to-date with LTS versions.Fixes #148