Tolerate plugins with warnings #437
Merged
+59
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frassle
force-pushed
the
fraser/runPlugin
branch
from
4bc2bd5 to
e2e76b3
Compare
Frassle
force-pushed
the
fraser/runPlugin
branch
from
e2e76b3 to
26951d3
Compare
tgummerer
approved these changes
Jan 27, 2025
|
Seems something is off with the tests not using the changes in the language host, works fine locally. |
Looking at CI, I don't think we're building the language runtime in the integration tests 😬 I thought I noticed that earlier and fixed it, but maybe that was for java? |
|
Ah no, we build in the makefile for |
No it's not. Most of the integration tests change the PATH env to pick up the right thing but in the places we do |
|
This PR has been shipped in release v3.72.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while on my adventures with dotnet plugins. If your plugin project has any warnings it's unusable in shimless mode (i.e.
RunPlugin) because msbuild would first print the warning then start the plugin and print the port number. This lead to errors like:When running shimless these warnings don't really matter. So this PR rewrites
RunPluginto do the build separately, and then invokedotnet runwith the--no-buildflag. I would have preferred to just usedotnet runbut there doesn't seem to be anyway to pass it flags to silence the msbuild output from it.This is tested by adding a warning to the testprovider project that always triggers. As we use the testprovider project in shimless mode in the integration tests this shows that a project with warnings can still be used.