Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[language-runtime] Implement GetRequiredPackages to replace GetRequiredPlugins #440

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

Zaid-Ajaj
Copy link
Contributor

@Zaid-Ajaj Zaid-Ajaj commented Jan 2, 2025

Description

The .NET language runtime currently uses GetRequiredPlugins to determine which resource plugins a program needs in order to run. However, GetRequiredPlugins doesn't account for the parameterization of the plugins. This is where GetRequiredPackages comes into play which allows the language runtime to return required plugins/packages along with their parameterization info (loaded from pulumi-plugin.json files).

This also allows the language runtime to correctly work with pulumi import for parameterized providers.

Fixes #432 and unskips tests:

  • l2-parameterized-resource
  • l2-explicit-parameterized-provider

Note: the tests were failing locally but that was because the local package nugets used in the conformance tests had old contents and needed to be invalidated. This so that pulumi-plugin.json could be filled with the parameterization values.

@Zaid-Ajaj Zaid-Ajaj added the area/language-host Runtime that executes user programs label Jan 2, 2025
@Zaid-Ajaj Zaid-Ajaj requested a review from a team as a code owner January 2, 2025 13:24
Copy link
Contributor

@tgummerer tgummerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do these logo.png files here come from? Do we really need them?

@Zaid-Ajaj
Copy link
Contributor Author

Where do these logo.png files here come from? Do we really need them?

@tgummerer Technically not required but they are part of SDK gen. We include them to change the icon on nuget.org for Pulumi packages

@Zaid-Ajaj Zaid-Ajaj added this pull request to the merge queue Jan 2, 2025
@tgummerer
Copy link
Contributor

We include them to change the icon on nuget.org for Pulumi packages

Thanks, TIL

Merged via the queue into main with commit a673844 Jan 2, 2025
19 checks passed
@Zaid-Ajaj Zaid-Ajaj deleted the zaid/get-required-packages branch January 2, 2025 14:53
@pulumi-bot
Copy link

This PR has been shipped in release v3.72.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/language-host Runtime that executes user programs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement GetRequiredPackages in the language host
3 participants