Support RunPlugin for Maven and Gradle plugins #1608
Merged
+539
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikhailshilkov
force-pushed
the
mikhailshilkov/runplugin
branch
2 times, most recently
from
c973271 to
a786e34
Compare
mikhailshilkov
force-pushed
the
mikhailshilkov/runplugin
branch
from
a786e34 to
f328017
Compare
lunaris
approved these changes
Feb 6, 2025
| public CompletableFuture<GetSchemaResponse> getSchema(GetSchemaRequest request) { | ||
| throw new UnsupportedOperationException("Method 'getSchema' is not implemented"); | ||
| } | ||
| } |
There was a problem hiding this comment.
Part of me thinks we should prefer interfaces with default implementations to abstract classes, but I don't know if there are important reasons to/to not to, so happy either way. I think Provider was an interface in TS and we found that a bit problematic at times, but TS interfaces don't support default implementations, so maybe that was it. Not sure.
There was a problem hiding this comment.
It's all internal for now in any case.
There was a problem hiding this comment.
At the point of this PR, interface sounds like a great idea. I converted it for now, let's see how we want it to evolve later. It's all internal for now, indeed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements RunPlugin for the Java provider host. It's implemented for both Maven and Gradle but not other executors. For now, I assume we don't want folks to author plugins with less popular package managers, but we can also add those later.
To test RunPlugin, I creates a very basic provider gRPC service that implements only GetSchema. My test provider returns a hard-coded schema, and then tests validate the it goes smoothly through the CLI. Later on we can enhance those tests to be real resource providers.
All SDK classes are in the
internalmodule.Resolve #1606